JavaScript - Adding text box values an storing it in an array

Question

i need some code corrected. So here is the JS:

var $ = function (id) {
    return document.getElementById(id);
}
var myTransaction = new Array[];

function processInfo() {
    var myItem = $('item').value;
    var myAmount = parseFloat($('amount').value);
    var myTotal = myItem + ":" + myAmount;

    var myParagraph = $('message');

    myParagraph.innerHTML = myTransaction;


    for (var theTotal in myTransaction) {
        myTransaction += addTogether[theTotal] + "<br>";
    }
}


window.onload = function () {
    $("addbutton").onclick = processInfo;
}

and HTML

<section>
    <p>Item:
        <input type="text" id="item" size="30">
        <p>Amount:
            <input type="text" id="amount" size="30">
            <p><span id="message">*</span>

                <p>
                    <input type="button" id="addbutton" value="Add Item" onClick="processInfo();">
</section>

What i need to do is get the values of the text boxes, and add them together into one variable then have it stored into the array. Then use a for-in loop to concatenate every element in the Array into a one String variable. However, must also stick a
tag at the end every value in the String, last thing is place this String in a paragraph at the end of the page.

FIDDLE

I can't figure out what you're trying to do. There's no array addTogether. First you set myTransaction to an empty array (except that's not the correct syntax). Then you put that into myParagraph.innerHTML, but that only makes sense if it contains a string. Then you loop over the empty array, and assign the variable as if it contains a string again. It makes so little sense, I don't know where to start to fix it. — Barmar
– Barmar, Commented Oct 13, 2013 at 20:07
You say you need to store something in array, but why do you need to do that? Arrays are for repetitive data, but there's only one item. — Barmar
– Barmar, Commented Oct 13, 2013 at 20:09

Dvir · Accepted Answer · 2013-10-13 20:19:58Z

1

If I understand you then look at my edition to your code: If you not understand something with the code so ask me.

At first you forget to close with ; the function $. then you create array with bad syntax. third you call addTogether array that doesn't exist. this is fixed code that i belive working like you asked.

var $ = function(id) {
    return document.getElementById(id);
};

var myTransaction = [];

function processInfo ()
{    
     var myItem = $('item').value;
     var myAmount = parseFloat($('amount').value);
     var myTotal = myItem + ":" + myAmount;
     var myParagraph = $('message');    

     myParagraph.innerHTML = "";
     myTransaction.push(myTotal);
     for (var theTotal in myTransaction)
     {
          myParagraph.innerHTML += myTransaction[theTotal] + "<br>"; 
     }

};

(function () {
    $("addbutton").onclick = processInfo;

})();

Edit
Mohamed-Ted suggest: instead of:

for (var theTotal in myTransaction)
{
     myParagraph.innerHTML += myTransaction[theTotal] + "<br>"; 
}

you can do this:

myParagraph.innerHTML += myTransaction.join("<br>");

see example on:
jsFiddle

edited Oct 13, 2013 at 20:19

answered Oct 13, 2013 at 20:12

Dvir

3,3382 gold badges23 silver badges34 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

TedMeftah Over a year ago

if you are using the for loop just to concatenate the array elements into a string, you can instead replace it with myParagraph.innerHTML = myTransaction.join("<br>")

Collectives™ on Stack Overflow

JavaScript - Adding text box values an storing it in an array

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related