pass string with spaces into javascript

Question

i'm trying to pass a php defined string with spaces to a javascript function, so that i can append to a query string. However, the function only works when there are NO spaces, and does not even execute when there are spaces -- by testing with alert().

is there a way I can pass strings with spaces into javascript functions, so that i can eventually do an escape(), and then append to my query string? (using alert() in this example)

.php file

<a onClick=showUser('<?php echo $stringwithspaces; ?>')>click here</a>

.js file

function showUser(str)
{
alert (str);
}

if I could only do something like... onClick=showUser(escape('<?php echo $deptname; ?>'))... that would be awesome, but that didn't work. Any help would be much appreciated! Thanks!

I don’t think the full contents of your PHP file have made it into the question. Could you edit it to get them in there? — Paul D. Waite
– Paul D. Waite, Commented Dec 21, 2009 at 12:19

outis · Accepted Answer · 2009-12-21 12:22:51Z

7

The problem is you didn't quote the attribute value. You can leave quotes off of attribute values only if the value doesn't contain spaces, otherwise the HTML processor can't tell when an attribute ends. Even so, it's not recommended; you should always quote HTML attributes.

<a href="showUser('<?php echo addslashes($username) ?>')">user</a>

should work. The call to addslashes escapes quotes, which would otherwise cause another problem (ending the attribute or string argument of showUser too soon).

edited Dec 21, 2009 at 12:22

answered Dec 21, 2009 at 12:17

outis

77.7k23 gold badges155 silver badges228 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Rees Over a year ago

Thank you a million! i can't believe how much time i spent trying to fix that error... very good lesson learned. Thank you :)

Patrick · Accepted Answer · 2009-12-21 12:18:58Z

1

Yes you can you are missing " in you xml attribute field: Each attribute must have a starting and an ending "

myField="blabla ..."

onClick="showUser(escape('<?php echo $deptname; ?>'))"

answered Dec 21, 2009 at 12:18

Patrick

15.7k1 gold badge41 silver badges39 bronze badges

2 Comments

Andy E Over a year ago

What you're saying is technically incorrect, even though it's relevant to the problem here, since quotation marks aren't required for HTML attributes, only XHTML and XML attributes. Without the quotes any value without a space in it would parse correctly.

Patrick Over a year ago

You re right but i think it will be better to start with good habits and quote each attribute :)

ewg · Accepted Answer · 2009-12-21 12:19:21Z

-1

Try the Unicode escape sequence for a space character, '\u0020'.

answered Dec 21, 2009 at 12:19

ewg

3191 silver badge3 bronze badges

Collectives™ on Stack Overflow

pass string with spaces into javascript

3 Answers 3

1 Comment

2 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related