Filling array with objects

Question

I have a class called Person which is like the following:

public class Person
{
    public static String name;
    public static int regNumber;

    public   String getName() {
       return name;
    }

    public  int getRegNumber() {
       return regNumber;
    }

    public Person(int x) {

       this.name = n;
       this.regNumber = x;
    }
}

I use this class to fill an array with students:

public class PeopleArray
{
    public static void main(String[]args) {

        Person [] students = new Person[3];
        int reg = 1;
        for (int i = 0; i<students.length; i++) {

           students[i] = new Person(reg++);

        }

        for (Person stu: students) {
           System.out.println(stu.getRegNumber());
        }

     }
}

The problem is that when I try to print out the ages of each individual person it seem that the array was filled with only the last object created by the Person class, because the only number that is printed is the number 2.

What am I doing wrong?

Remove the static modifier from your fields. And look up its meaning. — Sotirios Delimanolis
– Sotirios Delimanolis, Commented Oct 18, 2013 at 13:54

arshajii · Accepted Answer · 2013-10-18 13:56:04Z

5

The fields name and regNumber are static, which means they do not belong to any particular instance, but rather to the class as a whole. All you need to do is remove the static keyword from the field declarations in Person, making them instance variables instead of class variables.

I also suggest you read Understanding Instance and Class Members.

answered Oct 18, 2013 at 13:56

arshajii

130k26 gold badges246 silver badges293 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Juraj Blahunka · Accepted Answer · 2013-10-18 13:56:13Z

3

Try re-reading your Person field declaration:

public static String name;
public static int regNumber;

You have used static members, if you remove this keyword, it should start working.

answered Oct 18, 2013 at 13:56

Juraj Blahunka

18.6k6 gold badges38 silver badges52 bronze badges

Comments

Prabhakaran Ramaswamy · Accepted Answer · 2013-10-18 13:58:52Z

0

You need to remove static from the Your instance variables. if you used static in instance variables then last modified value is present in the name and regNumber.

public class Person{
    public String name;
    public int regNumber;

}

answered Oct 18, 2013 at 13:58

Prabhakaran Ramaswamy

26.1k10 gold badges61 silver badges65 bronze badges

Comments

sandu · Accepted Answer · 2013-10-18 18:21:47Z

0

Constructor in Person class assign a variable 'n' to the name. But you haven't defined it anywhere. Other than that, remove 'static' keyword from your variables.

answered Oct 18, 2013 at 18:21

sandu

1

Collectives™ on Stack Overflow

Filling array with objects

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related