PHP str_replace with mixed text and variables?

Question

I have a function and within the function I have:

$clean_dir = str_replace("temp_images/".$foldername."/output/", "", $dir);

$foldername value is outside the function.

When I run the above temp_images/xyz/output remains temp_images/xyz/output, but then I replace temp_images/xyz/output with xyz directly instead of $foldername. then it changes.

How can I insert mixed text with a variable in str_replace?

Thanks

use global $foldername; inside function to get $foldername variable value if it is outside the function. Can you show the whole code, please. — Subin
– Subin, Commented Oct 20, 2013 at 15:10
How can I insert mixed text with a variable in str_replace? -- what do you mean by that? What does var_dump($foldername); output? And what do you want the result to be? — Amal
– Amal, Commented Oct 20, 2013 at 15:13
@PannyMonium: Using global variables is widely regarded as a bad practice. Pass the variable as a function parameter instead. See my answer below. — Amal
– Amal, Commented Oct 20, 2013 at 15:19

Amal · Accepted Answer · 2013-10-20 15:15:07Z

4

I don't recommend using global variables. Pass $foldername as a function parameter instead:

function some_func($foldername) {
    ...
    $clean_dir = str_replace("temp_images/".$foldername."/output/", "", $dir);
    ...
}

answered Oct 20, 2013 at 15:15

Amal

76.8k18 gold badges133 silver badges154 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Panny Monium Over a year ago

I tried it as in function FolderToDropbox($dir, $dropbox_link, $foldername) but it didn't work

Amal Over a year ago

@PannyMonium: didn't work is not very descriptive. Add ini_set('display_errors',1); error_reporting(E_ALL); to the very top of your script and refresh the page. Do you get any errors?

Panny Monium Over a year ago

Missing argument 3 for FolderToDropbox()

Amal Over a year ago

@PannyMonium: The error is pretty self-explanatory, no? Fix your function call ;)

Panny Monium Over a year ago

Are you brave enough to answer this question? stackoverflow.com/questions/19483881/… :-)

Subin · Accepted Answer · 2013-10-22 14:41:39Z

-1

Pass a variable with the function :

function qwerty($foldername){
 ....
 $clean_dir = str_replace("temp_images/".$foldername."/output/", "", $dir);
 ....
}
qwerty("xyz");

Other Way (not good)

use global $foldername; inside function to get $foldername variable value if it is outside the function. Example :

$foldername="xyz";
function qwerty(){
 global $foldername;
 $clean_dir = str_replace("temp_images/".$foldername."/output/", "", $dir);
 ....
}

It's not a good practice to use global variable. Instead use the 1st example.

edited Oct 22, 2013 at 14:41

answered Oct 20, 2013 at 15:14

Subin

3,5731 gold badge36 silver badges65 bronze badges

3 Comments

Amal Over a year ago

If it's not a good practice, then why include it in your answer? :)

Subin Over a year ago

The user must know the both ways. Sometimes global is needed in desperate times. So other users who sees this answer might find it helpful.

ComFreek Over a year ago

@Subin I agree, but don't put the bad solution at the top of an answer. Most users will only take that and if it works, they won't give the actual solution a try.

Collectives™ on Stack Overflow

PHP str_replace with mixed text and variables?

2 Answers 2

5 Comments

Other Way (not good)

3 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

5 Comments

Other Way (not good)

3 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related