Javascript: can't access object property through for..in loop

Question

I am trying to access a property (name) on an object that is in fact located inside another object. I initialized the object in a file:

var icons = {

    "facebook": {name: 'facebook', icon_url: 'img/logos/facebook.png'}

};

And then tried to check the object with this code:

   var icon_current_class;

  for(var icon in icons){

    console.dir(icon);
    //outputs an object named facebook but says it has no properties

    if( $(this).hasClass( icon.name ) ){
      icon_current_class = icon.name;
    }else{
      alert("Something went wrong. Please contact the mods.");
    }
  }

And of course, the alert("Something went wrong") goes off everytime I run this. I have tried for a long time to find a solution, but to no avail. Can anyone please help?

You should just read the for...in documentation: developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/…. — Felix Kling
– Felix Kling, Commented Oct 20, 2013 at 22:27

OneOfOne · Accepted Answer · 2013-10-20 22:05:47Z

6

for(var x in y) x is the key of the object, you need to use y[x] to return the value:

for(var icon_name in icons){
    var icon = icons[icon_name];
    .....code....
}

answered Oct 20, 2013 at 22:05

OneOfOne

100k22 gold badges195 silver badges187 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Popnoodles Over a year ago

Is there an echo in here?

Marcos Pereira Over a year ago

ahaha thank you too! You actually explained the code you wrote, so thank you so much!

OneOfOne Over a year ago

@popnoodles i actually started typing my answer before yours, but my wifi dropped, you should get the answer tho.

Popnoodles · Accepted Answer · 2013-10-20 22:17:33Z

6

for(var icon in icons)

In the for loop, icon you're assigned there isn't an object, it's the index/key of each item.

for (var i in icons){
    console.dir(icons[i]);
...

edited Oct 20, 2013 at 22:17

answered Oct 20, 2013 at 22:03

Popnoodles

28.4k3 gold badges49 silver badges55 bronze badges

1 Comment

Marcos Pereira Over a year ago

Hmm, it didn't set in my mind why this worked yet, but thank you so much for the fast answer! :)

Collectives™ on Stack Overflow

Javascript: can't access object property through for..in loop

2 Answers 2

3 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related