php - if statement in a while loop

Question

I'm having problems getting my simple if-statement to work inside a PHP while loop. This is my code:

$p=mysql_query("SELECT * FROM forum_posts WHERE forum_id='$cid' AND topic_id='$id' AND post_deleted='0' ORDER BY post_time ASC LIMIT  $offset, $rowsperpage");

while($post=mysql_fetch_assoc($p)){ 
    $userpost=$user->getUserData($post['userid']);

          if($userpost['specialmembership'] == 1){
            $pioneer = "True";
          }
echo $userpost['username'];
echo $pioneer;

}

So, in the above example I have two different users. They are named user1 and user2.

User1 has specialmembership = 0
User2 has specialmembership = 1

The above code will output the following (the while loop in this example is getting looped 4 times):

It will output:

user1

user2
true

user1
true

user2
true

The problem is here, that the script is printing out true on user1 in the third loop. User1 shouldn't be set to true, only user2 should that, since he has specialmembership = 1;

What is wrong here?

Reset the value of $pioneer to false as the first line inside your while loop. — andrewsi
– andrewsi, Commented Oct 23, 2013 at 15:00

Luca Rainone · Accepted Answer · 2013-10-23 15:00:46Z

5

You should add an else

if($userpost['specialmembership'] == 1){
      $pioneer = "True";
}else {
     $pioneer = "False";
}

Because once the value of $pioneer is set does not change (if you don't do it again)

answered Oct 23, 2013 at 15:00

Luca Rainone

16.5k2 gold badges45 silver badges54 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Marc B · Accepted Answer · 2013-10-23 15:00:52Z

3

You never reset $pioneer after it's set to true, so ALL users after the first 'true' user will also be true. You need an else:

      if($userpost['specialmembership'] == 1){
        $pioneer = "True";
      } else {
        $pioneer = "False";  // <---you need this
      }

answered Oct 23, 2013 at 15:00

Marc B

362k44 gold badges433 silver badges508 bronze badges

Comments

noslone · Accepted Answer · 2013-10-23 15:00:52Z

3

Try following

$p=mysql_query("SELECT * FROM forum_posts WHERE forum_id='$cid' AND topic_id='$id' AND post_deleted='0' ORDER BY post_time ASC LIMIT  $offset, $rowsperpage");

while($post=mysql_fetch_assoc($p)){ 
    $userpost=$user->getUserData($post['userid']);

            $pioneer = "False";
          if($userpost['specialmembership'] == 1){
            $pioneer = "True";
          }
    echo $userpost['username'];
    echo $pioneer;
}

answered Oct 23, 2013 at 15:00

noslone

1,28910 silver badges14 bronze badges

Comments

ComFreek · Accepted Answer · 2013-10-23 15:00:57Z

1

As andrewsi said, you should reset you $pioneer variable each time you enter the loop.

while($post=mysql_fetch_assoc($p)){ 
  // defaults to 'False'
  $pioneer = 'False';
}

Another Option would be to introduce an else branch:

else {
  $pioneer = 'False';
}

Also, you should NOT use the deprecated MySQL extension anymore! Switch to MySQLi (with prepared Statements) or PDO!

answered Oct 23, 2013 at 15:00

ComFreek

29.5k18 gold badges107 silver badges157 bronze badges

Comments

Mooseman · Accepted Answer · 2013-10-23 15:01:41Z

1

You're not resetting the value of $pioneer after each loop. Reset it to an empty string if it's not supposed to be "true".

while($post=mysql_fetch_assoc($p)){ 
    $userpost=$user->getUserData($post['userid']);
        if($userpost['specialmembership'] == 1){
            $pioneer = "true";
        }else{
            $pioneer = "";
    echo $userpost['username'];
    echo $pioneer;
}

answered Oct 23, 2013 at 15:01

Mooseman

18.9k14 gold badges74 silver badges95 bronze badges

Comments

Yatin Trivedi · Accepted Answer · 2013-10-23 15:01:58Z

1

write

$p=mysql_query("SELECT * FROM forum_posts WHERE forum_id='$cid' AND topic_id='$id'      

AND post_deleted='0' ORDER BY post_time ASC LIMIT  $offset, $rowsperpage");

while($post=mysql_fetch_assoc($p)){ 
$userpost=$user->getUserData($post['userid']);
      $pioneer="False";
      if($userpost['specialmembership'] == 1){
        $pioneer = "True";
      }
echo $userpost['username'];
echo $pioneer;

}

answered Oct 23, 2013 at 15:01

Yatin Trivedi

6696 silver badges9 bronze badges

Comments

DKSan · Accepted Answer · 2013-10-23 15:02:10Z

1

You never reset your $Pioneer Variable

try

$pioneer = $userpost['specialmembership'] == 1 ? "True" : "False or Whatever you want";

answered Oct 23, 2013 at 15:02

DKSan

4,2073 gold badges27 silver badges35 bronze badges

Comments

Bhupesh Shrestha · Accepted Answer · 2017-05-17 16:40:56Z

0

Try adding else condition like

while($post=mysql_fetch_assoc($p)){ 
    $userpost=$user->getUserData($post['userid']);
          $pioneer = ($userpost['specialmembership'] == 1? "True": "False");
echo $userpost['username'];
echo $pioneer;
}

or define $pioneer = "False" in the beginning and use your code

while($post=mysql_fetch_assoc($p)){ 
$userpost=$user->getUserData($post['userid']);

      if($userpost['specialmembership'] == 1){
        $pioneer = "True";
      }
echo $userpost['username'];
echo $pioneer;

}

answered May 17, 2017 at 16:40

Bhupesh Shrestha

2483 silver badges17 bronze badges

Collectives™ on Stack Overflow

php - if statement in a while loop

8 Answers 8

Comments

Comments

Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

8 Answers 8

Comments

Comments

Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related