PHP Splitting data into 2 columns into an html table not working

Question

Hey guys I'm back and I feel like I'm making a really stupid error in my code but I can't seem to find it. What I am trying to do is split data retrieved from a mysql table into two columns inside an html table. So far I got it working...sort of. The problem I am having is the data keeps replicating to both rows in the table versus being an individual entry in each cell. I have used googled and searched these forms and can't seem to see where I am making the error. Below is the code

// Build the table
echo '
<table>
<tr>
';

// Build the headers
for ($x = '1'; $x <= '2'; $x++)
echo '

<td>Truck</td>
<td>Home Base</td>
<td>Client</td>
<td>Job Details</td>
<td>Crew</td>
 ';

 // Close off headers
 echo '</tr>';

 // Fetch the table contents if the rigs are active
 while($row = mysqli_fetch_array($truck_full_query)) {

for ($y = '1'; $y <= '1'; $y++):
    echo '<tr>';
        for ($z = '1'; $z <= '2'; $z++):
                    echo '<td>' . $row['model'] . ' #' . $row['position'] . '<br>' . $row['unit_number'] . '</td>';
                    echo '<td>' . $row['dispatch_location'] . '</td>';
                    // Get client information
            echo '<td>&nbsp;</td>';
            // Get Job Details
            echo '<td>&nbsp;</td>';
            // Get Crew
            echo '<td>&nbsp;</td>';
                endfor;
    echo '</tr>';
    endfor;
      }
     // Close table
    echo '</table>';

More or less just me fiddling trying to get this to work. Did a straight copy and paste. — John Smith
– John Smith, Commented Oct 23, 2013 at 20:02
cargo-cult programming warning: for($y = '1'; $<= '1' ...)`. for loops work on integers, not strings. and whye ven bother with a loop when you're only doing a SINGLE iteration? — Marc B
– Marc B, Commented Oct 23, 2013 at 20:02
@MarcB it works on strings too. But the question is what for? — u_mulder
– u_mulder, Commented Oct 23, 2013 at 20:04
where did you copy and paste $y = '1' from? i would actually be interested in looking at the rest of the code there. — gloomy.penguin
– gloomy.penguin, Commented Oct 23, 2013 at 20:08

u_mulder · Accepted Answer · 2013-10-23 20:14:33Z

1

// Build the table
echo '<table><tr>';

// Build the headers
echo '<td>Truck</td><td>Home Base</td><td>Client</td><td>Job Details</td><td>Crew</td>';   
echo '<td>Truck</td><td>Home Base</td><td>Client</td><td>Job Details</td><td>Crew</td>';
echo '</tr>';

$data = mysqli_fetch_all($truck_full_query);
$i = 0;
$t = sizeof($data);
for (; $i < $t; $i += 2) {
    echo '<tr>';
    $left_row = $data[$i];
    echo '<td>' . $left_row['model'] .'</td><td>...</td><td>...</td><td>...</td><td>...</td>';
    $right_row = $data[$i + 1];
    echo '<td>' . $right_row['model'] .'</td><td>...</td><td>...</td><td>...</td><td>...</td>';
    echo '</tr>';
}

echo '</table>

And don't forget to check if the last $right_row exists.

answered Oct 23, 2013 at 20:14

u_mulder

54.8k5 gold badges54 silver badges72 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

John Smith Over a year ago

Looks like this might work but I'm getting a mysqli_fetch_all() error so I might need to play with it a bit to get it to work.

John Smith Over a year ago

Still no luck getting it to work, but I'll keep fidgeting with it after supper.

Collectives™ on Stack Overflow

PHP Splitting data into 2 columns into an html table not working

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related