Array just keeps adding object and memory Crash

Question

I am recently having a memory crash and I am suspecting that I am failing to empty the array, This is my code for the array

- (void)viewDidLoad
{
   allImagesArray = [[NSMutableArray alloc] init];
    NSArray *paths = NSSearchPathForDirectoriesInDomains(NSDocumentDirectory, NSUserDomainMask, YES);
    NSString *documentsDirectory = [paths objectAtIndex:0];
    NSString *location=@"Bottoms";
    NSString *fPath = [documentsDirectory stringByAppendingPathComponent:location];
    NSArray *directoryContent = [[NSFileManager defaultManager] directoryContentsAtPath: fPath];
    collectionBottoms.delegate =self;
    collectionBottoms.dataSource=self;
    for(NSString *str in directoryContent){
        NSLog(@"i");
        NSString *finalFilePath = [fPath stringByAppendingPathComponent:str];
        NSData *data = [NSData dataWithContentsOfFile:finalFilePath];
        if(data)
        {
            UIImage *image = [UIImage imageWithData:data];
            [allImagesArray addObject:image];
            NSLog(@"array:%@",[allImagesArray description]);

        }}
}

Ho can I free the memory by releasing the object in the array?

Exactly...as long as they are in the array they will be alive. — borrrden
– borrrden, Commented Oct 25, 2013 at 4:10
I can't find a place to do that, I know you put the code [allImagesArray removeAllObjects]; NSLog(@"%@", allImagesArray);}but cannot find a good place to put it. I want to save the picture first to save to document however if I put this above code it just deletes the picture that I just took. — interdatega
– interdatega, Commented Oct 25, 2013 at 4:14
Then don't use that method. What's wrong with removeObject: or removeObjectAtIndex:? It would be pretty foolish to have an array where you could only remove every object, don't you think? — borrrden
– borrrden, Commented Oct 25, 2013 at 4:22

TamilKing · Accepted Answer · 2013-10-25 04:27:06Z

1

You save the image array in Plist. After save you just re initialize your array it will clear the memory in array. Then are you using ARC or not? Because ARC is more comfortable for this. Then re-initialze or removeAllObject from array in -viewWillDisappear

answered Oct 25, 2013 at 4:27

TamilKing

1,6431 gold badge12 silver badges23 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Nirmalsinh Rathod · Accepted Answer · 2013-10-25 04:43:18Z

0

Hi Just release the memory once object works is over. Here is the code for you.

- (void)viewDidLoad
{
   allImagesArray = [[NSMutableArray alloc] init];
    NSArray *paths = NSSearchPathForDirectoriesInDomains(NSDocumentDirectory, NSUserDomainMask, YES);
    NSString *documentsDirectory = [paths objectAtIndex:0];
    NSString *location=@"Bottoms";
    NSString *fPath = [documentsDirectory stringByAppendingPathComponent:location];
    NSArray *directoryContent = [[NSFileManager defaultManager] directoryContentsAtPath: fPath];
    collectionBottoms.delegate =self;
    collectionBottoms.dataSource=self;
    for(NSString *str in directoryContent)
    {
        NSString *finalFilePath = [fPath stringByAppendingPathComponent:str];
        NSData *data = [NSData dataWithContentsOfFile:finalFilePath];
        if(data)
        {
            UIImage *image = [UIImage imageWithData:data];
            [allImagesArray addObject:image];
            NSLog(@"array:%@",[allImagesArray description]);
        image = nil;

        }
    finalFilePath=nil;
    data=nil;
   }

 paths= nil;
 documentsDirectory= nil;
 location= nil;
 fPath= nil;
 directoryContent = nil;
}

answered Oct 25, 2013 at 4:43

Nirmalsinh Rathod

5,2414 gold badges28 silver badges58 bronze badges

2 Comments

interdatega Over a year ago

This looks like it will help and it does decrease the memory but it still builds up after taking many photo. Does this have problems with the camera code or something else. This is my whole code github.com/laryufk/Helper/tree/master for the camera is there something wrong.

Nirmalsinh Rathod Over a year ago

You have to nil or release the object once its works get over. So you can have check your code release the memory.

Ashok · Accepted Answer · 2013-10-25 04:59:12Z

0

If you are using this image array, allImagesArray, when the view is visible then put this code in viewWillAppear or viewDidAppear methods of UIViewController.

- (void)viewWillAppear:(BOOL)animated
{
    [super viewWillAppear:animated];

   allImagesArray = [[NSMutableArray alloc] init];
    NSArray *paths = NSSearchPathForDirectoriesInDomains(NSDocumentDirectory, NSUserDomainMask, YES);
    NSString *documentsDirectory = [paths objectAtIndex:0];
    NSString *location=@"Bottoms";
    NSString *fPath = [documentsDirectory stringByAppendingPathComponent:location];
    NSArray *directoryContent = [[NSFileManager defaultManager] directoryContentsAtPath: fPath];
    collectionBottoms.delegate =self;
    collectionBottoms.dataSource=self;
    for(NSString *str in directoryContent){
        NSLog(@"i");
        NSString *finalFilePath = [fPath stringByAppendingPathComponent:str];
        NSData *data = [NSData dataWithContentsOfFile:finalFilePath];
        if(data)
        {
            UIImage *image = [UIImage imageWithData:data];
            [allImagesArray addObject:image];
            NSLog(@"array:%@",[allImagesArray description]);

        }
    }
}

And, then release it in viewWillDisappear/viewDidDisappear methods of UIViewController.

- (void)viewDidDisappear:(BOOL)animated
{
    [super viewDidDisappear:animated];

    [allImagesArray removeAllObjects];
    //[allImagesArray release]; // (Uncomment) Call this only if you are not using ARC.
}

Alternatively, a quick, dirty but safe fix is (without knowing your usage of allImagesArray) -

- (void)viewDidLoad
{
    [super viewDidLoad];

     // Remove previously added objects.
     if (allImagesArray != nil && allImagesArray.count > 0) {
            [allImagesArray removeAllObjects];
     }
     // Allocate memory if not done earlier (i.e. first time).
     if (allImagesArray == nil) {
        allImagesArray = [[NSMutableArray alloc] init];
     }

     // Rest of your code as stated in your question
}

edited Oct 25, 2013 at 4:59

answered Oct 25, 2013 at 4:26

Ashok

6,2542 gold badges40 silver badges56 bronze badges

2 Comments

interdatega Over a year ago

I don't get the code that is written at the bottom which line should I put this and why is it viewWillappear not viewdidload?

Ashok Over a year ago

Clarified the code for alternative approach above. viewWillAppear is called everytime view is presented on screen and viewDidDisappear when its removed of screen. These are UIViewController methods. Read official docs for more details here - developer.apple.com/library/ios/documentation/uikit/reference/…

Collectives™ on Stack Overflow

Array just keeps adding object and memory Crash

3 Answers 3

Comments

2 Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

2 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related