JS function does not update HTML string

Question

Im pretty new to JS and HTML (started ~20 hours ago) and already have a problem: below you can see my code. As one tutorial said, clicking on button will change the statusLine text. But something went wrong and i cant figure it out.

    <!DOCTYPE html>
<html>
<head>
<title>Некое подземелье</title>
</head>
<body>
<p id="statusLine">Вы попали в подземелье.</p>

<button type="button" onclick="goDeeper()">Идти глубже в подземелье</button>

<script>
    function goDeeper()
     {
       var nextEvent=(Math.floor(Math.random()*10+1));
       switch(nextEvent){
        case'1':
            document.getElementById("statusLine").innerHTML="Вам на пути попался гоблин!";
            break;
                }
     }
</script>
</body>
</html>

So, something is wrong. What should i do in order to fix this?

What does the javascript console say? And what should happen if nextEvent is not '1' — NilsH
– NilsH, Commented Nov 3, 2013 at 20:24

p.s.w.g · Accepted Answer · 2013-11-03 20:25:39Z

3

Try making the case statement match the number 1 rather than the string '1':

function goDeeper()
{
    var nextEvent = Math.floor(Math.random()*10+1);
    switch(nextEvent) {
        case 1:
            document.getElementById("statusLine").innerHTML="Вам на пути попался гоблин!";
            break;
    }
}

Or for that matter, if there is only one condition you need to match, just get rid of the switch and use a simple if block:

function goDeeper()
{
    var nextEvent = Math.floor(Math.random()*10+1);
    if (nextEvent == 1) {
        document.getElementById("statusLine").innerHTML="Вам на пути попался гоблин!";
    }
}

answered Nov 3, 2013 at 20:25

p.s.w.g

150k31 gold badges307 silver badges339 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Zeshan · Accepted Answer · 2013-11-03 20:30:13Z

0

What I understand you want to change the text on click button so Try this 

<!DOCTYPE html>
<html>
<head>
<script>
function myFunction()
{
document.getElementById("demo").innerHTML="Hello World";
}
</script>
</head>
<body>

<p>Click the button to trigger a function.</p>

<button onclick="myFunction()">Click me</button>

<p id="demo"></p>`enter code here`

</body>
</html>

Refrence Link : http://www.w3schools.com/jsref/tryit.asp?filename=tryjsref_onclick

answered Nov 3, 2013 at 20:30

Zeshan

757 bronze badges

Collectives™ on Stack Overflow

JS function does not update HTML string

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related