How to put arraylist on button onclick method?

Question

I want to put ArrayList on onClick method. But it tell me i should change arraylist to final(i will put something in there so can't). how should i put arraylist in it!?

  protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);
    final TextView txt1;
    Button btn1;


     ArrayList <String> shop= new ArrayList <String>();
    impshop(shop);

    txt1 =(TextView)findViewById(R.id.tv1);
    btn1 =(Button)findViewById(R.id.button1);

    btn1.setOnClickListener(new OnClickListener(){

        @Override
        public void onClick(View v) {
            // TODO Auto-generated method stub
            Random ran = new Random();
            int choose = ran.nextInt(shop.size());  
            txt1.setText(shop.get(choose));
        }});

}

can i onClick(View v,ArrayList shop) ?

usually, eclipse gives you an error, and the quick fix is too make the variable final, which effectively solves the issue. — njzk2
– njzk2, Commented Nov 5, 2013 at 15:46
I think you can't do it, since the OnClickListener must implement the inherited abstract method onClick(View) — GVillani82
– GVillani82, Commented Nov 5, 2013 at 15:54

Aedis · Accepted Answer · 2013-11-05 15:53:39Z

1

Besides adding final to your ArrayList, you may also define it outside onCreate method. Doing so does not require you to define final modifier.

Though be sure to not use the ArrayList to store elements that belong to the Activity's Context or elements that might be linked to other contexts of the application, failing to do so might result in big memory leaks.

edited Nov 5, 2013 at 15:53

Aedis

4233 silver badges6 bronze badges

answered Nov 5, 2013 at 15:44

waqaslam

68.3k17 gold badges172 silver badges180 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Boris Pavlović · Accepted Answer · 2013-11-05 15:43:02Z

0

Add final before

ArrayList <String> shop= new ArrayList <String>();

so it looks like:

final ArrayList <String> shop= new ArrayList <String>();

answered Nov 5, 2013 at 15:43

Boris Pavlović

64.9k29 gold badges127 silver badges150 bronze badges

Comments

Avo Muromägi · Accepted Answer · 2013-11-05 16:10:08Z

0

protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);
    final TextView txt1;
    Button btn1;

    final ArrayList <String> shop= new ArrayList <String>();
    impshop(shop);

    txt1 =(TextView)findViewById(R.id.tv1);
    btn1 =(Button)findViewById(R.id.button1);

    btn1.setOnClickListener(new OnClickListener(){

    @Override
    public void onClick(View v) {
        // TODO Auto-generated method stub
        Random ran = new Random();
        int choose = ran.nextInt(shop.size());  
        txt1.setText(shop.get(choose));
    }});
}

or declare your ArrayList as a field

edited Nov 5, 2013 at 16:10

Avo Muromägi

1,6131 gold badge13 silver badges21 bronze badges

answered Nov 5, 2013 at 15:45

Dardan

5317 silver badges15 bronze badges

Collectives™ on Stack Overflow

How to put arraylist on button onclick method?

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related