java.sql.SQLSyntaxErrorException: ORA-00936: missing expression

Question

I wrote a simple SQL query in Oracle which inserts some values.

But I got SQLSyntaxErrorException stating a "missing expression" error.

This my query:

String addManager = "INSERT INTO property_manager(EIN,NAME,HOME_PHONENUMBER,MOBILE_PHONENUMBER,EMAIL,PROPERTY_CIN)" +
       "VALUES (" + mein.getText() + ","  + mname.getText() +","+    mHome_phonenumber.getText() +","+ MMobile_phonenumber.getText()+"," + memail.getText() + ","+mproperty_cin.getText()+")";

Amir Pashazadeh · Accepted Answer · 2013-11-21 20:20:28Z

2

The best solution is using a java.sql.PreparedStatement.

It prevents SQL injection
Escapes invalid characters in your Strings (such as ') and the characters which will break your query
handles null and empty Strings
Uses Oracle's query parsing cache (for better performance)
Handles types such as Date and Blob much easier

Just google for java PreparedStatemnt and you see lots of samples.

answered Nov 21, 2013 at 20:20

Amir Pashazadeh

7,3124 gold badges44 silver badges71 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Bohemian · Accepted Answer · 2013-11-21 20:14:08Z

0

You should put your values inside quotes.

String addManager = "INSERT INTO property_manager(EIN,NAME,HOME_PHONENUMBER,MOBILE_PHONENUMBER,EMAIL,PROPERTY_CIN)" +
   "VALUES ('" + mein.getText() + "','"  + mname.getText() +"','"+    mHome_phonenumber.getText() +"','"+ MMobile_phonenumber.getText()+"','" + memail.getText() + "','"+mproperty_cin.getText()+"')";

Or better yet, use parameters. Otherwise you risk sql injection attack.

edited Nov 21, 2013 at 20:14

Bohemian♦

427k103 gold badges603 silver badges750 bronze badges

answered Nov 21, 2013 at 20:01

Alen Oblak

3,32515 silver badges27 bronze badges

1 Comment

user3019128 Over a year ago

how to put my values inside quotes can u write for me? thanks

Collectives™ on Stack Overflow

java.sql.SQLSyntaxErrorException: ORA-00936: missing expression

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related