Making CheckBox checked dynamically using setChecked(True)

Question

i have a Listview and each row of listview has a checkbox, now i want to dynamically check or uncheck Checkboxes according to data coming from database, for this i am using checkBox.setChecked(true) method, but checkboxes are not properly checked and unchecked according to data coming from database, please anyone help me. Thanks in advance. Here is My code :

public class Adaptor_CategoryList extends ArrayAdapter<Category> {
public Context mContext;
public ArrayList<Category> listCategory;
public LayoutInflater inflater;
// public OnCheckedChangeListener listnerCheckBox;
public OnCheckedChangeListener listnerCheckBox;

// this arraylist for making checkbox checked and unchecked
public ArrayList<Integer> listCatIds;

public Adaptor_CategoryList(Context context, int resource,
        List<Category> objects, OnCheckedChangeListener listener,
        ArrayList<Integer> listIds) {
    super(context, resource, objects);
    // TODO Auto-generated constructor stub
    mContext = context;
    listCategory = (ArrayList<Category>) objects;
    inflater = (LayoutInflater) mContext
            .getSystemService(Context.LAYOUT_INFLATER_SERVICE);
    listnerCheckBox = listener;
    listCatIds = listIds;

} // constructor ends

public View getView(int position, View convertView, ViewGroup parent) {
    View holder = convertView;
    if (holder == null) {
        holder = inflater.inflate(R.layout.dialog_categorylist, null);
    }
    if (listCategory.size() != 0) {
        TextView txtName = (TextView) holder
                .findViewById(R.id.EditItem_dialogtxtName);
        CheckBox checkCategory = (CheckBox) holder
                .findViewById(R.id.EditItem_dialogCheckBox);
        checkCategory.setTag(position);
        checkCategory.setOnCheckedChangeListener(listnerCheckBox);
        // checkCategory.setOnCheckedChangeListener(listnerCheckBox);
        Category objCategory = listCategory.get(position);
        if (objCategory != null) {
            if (listCatIds.size() > 0) {
                // code for making checkbox checked accroding to item
                // category

                for (int i = 0; i < listCatIds.size(); i++) {
                    int catId = listCatIds.get(i);
                    int id = objCategory.getCatId();

                    if (id == catId) {

                        checkCategory.setChecked(true);

                        System.out
                                .println("checkbox is checked ////// id is  "
                                        + id);
                    } else {
                        checkCategory.setChecked(false);

                    }
                }
            }
            String strName = objCategory.getName();
            if (strName != null) {
                txtName.setText(strName);

            }
        }
    }
    return holder;
}// method ends

} // final class ends

here is my listener defined in other Activty:

CompoundButton.OnCheckedChangeListener listenerCheckBox = new CompoundButton.OnCheckedChangeListener() {

    @Override
    public void onCheckedChanged(CompoundButton buttonView,
            boolean isChecked) {
        // TODO Auto-generated method stub
        try {
            // adding item to category on checkbox checked
            if (isChecked) {
                Object tag = buttonView.getTag();
                if (tag != null) {
                    int position = (Integer) tag;
                    Category objCat = listCategory.get(position);
                    int catId = objCat.getCatId();
                    db.open();
                    long rowId = db.addItemToCategory(itemId, catId);
                    // Toast.makeText(mContext,
                    // "Add Id is"+rowId,Toast.LENGTH_LONG).show();

                    db.close();
                }

            }
            // removing item from category on checkbox unchecked
            else if (!isChecked) {
                Object tag = buttonView.getTag();
                if (tag != null) {
                    int position = (Integer) tag;
                    Category objCat = listCategory.get(position);
                    int catId = objCat.getCatId();
                    db.open();
                    long rowId = db.deleteItemFromCategory(
                            itemId + "".trim(), catId + "".trim());
                    db.close();

                }

            }
        } catch (Exception e) {
            // TODO: handle exception
        }

    }
};

However, this log System.out.println("checkbox is checked ////// id is "+ id); printed on Logcat when if condition satisfies but checkbox do not change its state.please provide me some suggestion.

Is it working without the listener? ie, without the line checkCategory.setOnCheckedChangeListener(listnerCheckBox); — Nizam
– Nizam, Commented Nov 22, 2013 at 8:24

npace · Accepted Answer · 2013-11-22 08:25:19Z

1

You have to update the list view so it can reflect the new data. There are two ways you can do this - the first is to call notifyDataSetChanged() on your adapter, which will refresh every recyclable view in the list. It takes exactly one line of code, but it's a bit wasteful and causes unnecessary invalidation and drawing.

The second way is to call your adapter's getView method manually. Here's what I personally do:

    public void updateSingleRow(int position)
{
    // Get the view manually in order to update it, but only if 
    // the position in need of invalidation is visible in the list view.
    if (position >= listView.getFirstVisiblePosition() && position < listView.getLastVisiblePosition())
    {
        View v = ((ViewGroup) listView.getChildAt(listView.getHeaderViewsCount() + (position - listView.getFirstVisiblePosition()))).getChildAt(0);
        adapter.getView(position, v, listView);
    }
}

answered Nov 22, 2013 at 8:25

npace

4,2581 gold badge27 silver badges36 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Dhiraj Choudhary Over a year ago

Actually this listview is in dialog, so i already had called notifydatasetChanged() method.

user229044 · Accepted Answer · 2017-06-17 12:11:52Z

0

this is most likely because you are not updating it on the UI Thread.

Try this:

runOnUiThread(new runnable(){
    public void run(){
        checkCategory.setChecked(true);
    }
});

edited Jun 17, 2017 at 12:11

user229044♦

241k41 gold badges347 silver badges350 bronze badges

answered Nov 22, 2013 at 8:10

sternze

1,6442 gold badges10 silver badges15 bronze badges

1 Comment

Dhiraj Choudhary Over a year ago

but i am already updating it from Ui thread. please explain your answer.

Collectives™ on Stack Overflow

Making CheckBox checked dynamically using setChecked(True)

2 Answers 2

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related