Java: While Loop and array incrementing

Question

I want the program to keep incrementing the innings for each iteration of the loop. When I run the program it's doing that, however it's showing me incorrect values.

For example: You rolled...4 Your total for this innings so far is 6

The second line should be showing, "... so far is 4"

This is the code that I have at the moment:

import java.util.Random;
import javax.swing.*;

public class shortSix {

    public static void main(String[] args) {
        diceGame();
}//ENDS MAIN
    public static void diceGame()
    {
        final int[] innings = new int[1];
        innings[0] = 0;

        Random dice = new Random();
        int diceRoll = dice.nextInt(6) + 1;

        while (diceRoll != 5)
        {
            System.out.println("You rolled..." + diceRoll);
            diceRoll = dice.nextInt(6) + 1;
            innings[0] =+ diceRoll;
            System.out.println("Your total for this innings so far is " + innings[0]);

            String userDeclare = JOptionPane.showInputDialog(null, "Do you wish to declare?");
            if (userDeclare.equals("yes"))
            {
                System.exit(0);
            }

        }
    }//ENDS diceGame
}//ENDS class shortSix

I'm supposed to use a final variable to store values for this question — AbbenGabben
– AbbenGabben, Commented Nov 23, 2013 at 14:09

Mateusz · Accepted Answer · 2013-11-23 14:09:03Z

4

The problem is that you aren't updating the array record after the first roll. You've got int diceRoll = ..., then you assign random value to the variable again and add the score after the second roll. The first result is ignored. All you have to do is change

diceRoll = dice.nextInt(6) + 1;
innings[0] =+ diceRoll;

to

innings[0] =+ diceRoll;
diceRoll = dice.nextInt(6) + 1;

answered Nov 23, 2013 at 14:09

Mateusz

3,0584 gold badges30 silver badges42 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

AbbenGabben Over a year ago

I would have marked this as the accepted answer, however I have to wait for another 7 mins. I changed the order around and modified the =+ to +=

yeputons · Accepted Answer · 2013-11-23 14:10:56Z

2

There are two problems:

=+ instead of += before the second println
Order of operations is strange. You first print the current value, then update it and only then increases counter and prints summary. Probably you wanna move diceRoll = dice... after the second println

answered Nov 23, 2013 at 14:10

yeputons

9,3081 gold badge37 silver badges72 bronze badges

1 Comment

AbbenGabben Over a year ago

Ahh that makes sense. I've changed it around now and it's working fine.

Ali Hashemi · Accepted Answer · 2013-11-23 14:10:47Z

1

You call

diceRoll = dice.nextInt(6) + 1;

before printing

 System.out.println("Your total for this innings so far is " + innings[0]);

which causes making a new random number, and it is the problem.

answered Nov 23, 2013 at 14:10

Ali Hashemi

3,4283 gold badges36 silver badges48 bronze badges

Collectives™ on Stack Overflow

Java: While Loop and array incrementing

3 Answers 3

1 Comment

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related