Comparing substring in another string in javascript

Question

I have two string I want to check if substring of one variable into another variable below is the code snippets.

var val1 = "www.google.com , www.yahoo.com , www.msn.com, in.news.yahoo.com";
    var val2 = "in.news.yahoo.com/huffington-post-removes-sonia-gandhi-rich-list-103404344.html";
//if val1 does not contains val2 I want to show popup. I tried val1 .toLowerCase().indexOf(val2 .toLowerCase()) but it doesn't work it always return -1.

can any one suggest me how can I put if condition?

That's because you are checking whether val2 is a substring of val1, not any substring of val2 is a substring of val1. — mcserep
– mcserep, Commented Dec 3, 2013 at 16:16

Ringo · Accepted Answer · 2013-12-03 16:35:22Z

1

Try this:

var val1 = "www.google.com,www.yahoo.com,www.msn.com,in.news.yahoo.com";
var val2 = "www.yahoo.com/huffington-post-removes-sonia-gandhi-rich-list-103404344.html";

function check(){
    var val1_arr = val1.split(',');
    for(var i = 0; i < val1_arr.length; i++){
       if(val2.indexOf(val1_arr[i]) != -1){
         // val2 contains val1
           return true;
       }
    }
    return false;
}

edited Dec 3, 2013 at 16:35

answered Dec 3, 2013 at 16:21

Ringo

3,9873 gold badges25 silver badges38 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

David Neale Over a year ago

Would be better to remove the need for jQuery. Plus [].each won't work. It'll need to be $.each(var1_arr, function(...

Ringo Over a year ago

Sorry, I have just checked this. Try it again!

James Lai Over a year ago

In your code, if val2 contains multiple instances of val1, you're going to get multiple popups.

RononDex · Accepted Answer · 2013-12-03 16:21:26Z

0

try this:

val1 = [ "www.google.com",
         "www.yahoo.com",
         "www.msn.com",
         "in.news.yahoo.com" ];

function showPopUpIfUrlIsInVal1(val2) {
    var b = false;

    for (var i = 0; i < val1.length; i++)
    {
        if (val2.indexOf(val1[i]) > -1)
        {
            b = true;
            break;
        }
    }

    if (b)
    {
         alert("test message");
    }
}

showPopUpIfUrlIsInVal1("http://www.google.com");

answered Dec 3, 2013 at 16:21

RononDex

4,19526 silver badges40 bronze badges

Comments

James Lai · Accepted Answer · 2013-12-03 16:28:14Z

0

Ah, this is a fun one, here's a FP way of solving this problem:

var val1 = "www.google.com , www.yahoo.com , www.msn.com,in.news.yahoo.com";
var val2 = "in.news.yahoo.com/huffington-post-removes-sonia-gandhi-rich-list-103404344.html";

function arrayInString(needles, haystack, callback) {
    var result = needles.some(function(el) {
        return haystack.indexOf(el.trim()); // Trim is required to remove extra whitespace
    });
    if (result) callback();
}

arrayInString(val1.split(","), val2, function() {
    // Create your popup here
});

answered Dec 3, 2013 at 16:28

James Lai

2,07117 silver badges15 bronze badges

Comments

A. Wolff · Accepted Answer · 2013-12-03 16:33:31Z

0

You can use Array.prototype.filter method:

jsFiddle

   //fixing val1 format    
   var val1 = "www.google.com , www.yahoo.com , www.msn.com , in.news.yahoo.com";

    var matched = val1.split(' , ').filter(function (v) {
        return ~val2.indexOf(v);
    });

edited Dec 3, 2013 at 16:33

answered Dec 3, 2013 at 16:28

A. Wolff

74.4k9 gold badges98 silver badges158 bronze badges

Collectives™ on Stack Overflow

Comparing substring in another string in javascript

4 Answers 4

3 Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

3 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related