Php Input Validation not responding

Question

I am new to the web developing world.Please bare w/ me for having some mistakes and insufficient knowledge.

I'm trying to study the validation process of a users input. Below is my Code:

<?php

if($_POST['formSubmit'] == "Search") 
{
  $errorMessage = "";

  if(empty($_POST['formName'])) 
  {
    $errorMessage .= "<li>No Input</li>";
  }

  $varName = $_POST['formName'];

  if(!empty($errorMessage)) 
  {
    echo("<p>There was an error with your form:</p>\n");
    echo("<ul>" . $errorMessage . "</ul>\n");
  } 

}

?>

<form action="index.php" method="post">
<input type="text" name="formName" value="<?=$varName;?>">
<input type="Submit" name="formSubmit" value=" Search">
</form>

What I think should happen is when the user click the search button without inputting anything an error message will pop-up, but I don't understand why its not responding or echoing the error message, i've check the names and values but Alas, Appreciate all the help/suggestions you could give tnx.

Thanks for the reply everyone, got it into working ^_^

The value of your submit button has an extra space in front, so the if block doesn't execute. — kinghfb
– kinghfb, Commented Dec 5, 2013 at 10:14
Also if you just compare $_POST['formSubmit'] in a if and for any reason someone doesn't pass any parameter with that name it will pop a warning. To avoid this you can check if any value was passed or not before comparing it using isset() — Naryl
– Naryl, Commented Dec 5, 2013 at 10:20

Elon Than · Accepted Answer · 2013-12-05 10:15:10Z

1

Your $_POST['formSubmit'] doesn't contain Search. It contains Search (with space in front of it).

Because of that PHP will never validate your form.

answered Dec 5, 2013 at 10:15

Elon Than

9,8154 gold badges29 silver badges37 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user3056723 Over a year ago

wow didn't see that coming thank you sir, I feel like a total loser haha. It worked, Love this community thanks

Acelasi Eu · Accepted Answer · 2013-12-05 10:18:04Z

1

This works:

<?php

if($_POST['formSubmit'] == "Search") 
{
  $errorMessage = "";

  if(empty($_POST['formName'])) 
  {
    $errorMessage .= "<li>No Input</li>";
  }

  $varName = $_POST['formName'];

  if(!empty($errorMessage)) 
  {
    echo("<p>There was an error with your form:</p>\n");
    echo("<ul>" . $errorMessage . "</ul>\n");
  } 

}

?>

<form action="index.php" method="post">
<input type="text" name="formName" value="<?=$varName;?>">
<input type="Submit" name="formSubmit" value="Search">
</form>

answered Dec 5, 2013 at 10:18

Acelasi Eu

9142 gold badges9 silver badges30 bronze badges

Comments

himanshu bhardiya · Accepted Answer · 2013-12-05 10:23:49Z

1

you need to use isset() function

<?php
if(isset($_POST['formSubmit'])) 
{
  $errorMessage = "";

  if(empty($_POST['formName'])) 
  {
   echo $errorMessage .= "No Input";
  }
 else
 {
    $varName = $_POST['formName'];
 } 

}

 ?>

<form action="index.php" method="post">
<input type="text" name="formName" value="<?=$varName;?>">
<input type="Submit" name="formSubmit" value="Search">
</form>

edited Dec 5, 2013 at 10:23

answered Dec 5, 2013 at 10:18

himanshu bhardiya

811 silver badge9 bronze badges

1 Comment

Naryl Over a year ago

still got the typo :p second line.

Roopendra · Accepted Answer · 2013-12-05 10:17:13Z

0

You giving wrong name to your submit button .

<input type="Submit" name="formSubmit" value=" Search">

it should be

<input type="Submit" name="formSubmit" value="Search">

answered Dec 5, 2013 at 10:17

Roopendra

7,75716 gold badges72 silver badges95 bronze badges

Comments

praveen · Accepted Answer · 2013-12-05 10:18:28Z

0

Change this line

if($_POST['formSubmit'] == "Search") 

to

if(isset($_POST['formSubmit']))

answered Dec 5, 2013 at 10:18

praveen

2861 silver badge9 bronze badges

Comments

Akhil · Accepted Answer · 2013-12-05 10:23:35Z

I am making some corrections. Please use this.

<?php
if($_POST['formSubmit'] == "Search") {
    $errorMessage = "";
    if(empty($_POST['formName'])) {
        $errorMessage .= "<li>No Input</li>";
    } else {
        $varName = $_POST['formName'];
    }
    if(!empty($errorMessage)) {
        echo("<p>There was an error with your form:</p>\n");
        echo("<ul>" . $errorMessage . "</ul>\n");
    } 
}
?>

<form action="index.php" method="post">
    <input type="text" name="formName" value="<?=$varName;?>">
    <input type="Submit" name="formSubmit" value="Search">
</form>

Corrected the condition if($_POST['formSubmit'] == "Search")
IF $_POST['formName'] is empty then no need for assigning so put it inside else condition.

Collectives™ on Stack Overflow

Php Input Validation not responding

6 Answers 6

1 Comment

Comments

1 Comment

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

1 Comment

Comments

1 Comment

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related