javascript: call method in an object from string

Question

I'm trying to make a controller for my app. I'm not able to do what I want and I don't understand why :-( I'm not a javascript expert so probably I'm doing something that is not allowed. Error from firebug:

TypeError: window[("Controller." + where)] is not a function

The error is clear, but why is this happening?

jsFiddle: http://jsfiddle.net/TB8yr/1/

var Controller= function(){
    this.currentpage='home';

}

Controller.prototype.route=function(where){

    window["Controller."+where]();
};

Controller.prototype.goHome=function(){
    alert('route gohome');

}

Controller.prototype.goBack=function(){
    alert('route goback');

}

//////
test=new Controller();
test.route('goHome');

Controller is not in window. Do var Controller = window.Controller = ... — marekful
– marekful, Commented Dec 6, 2013 at 16:51

antyrat · Accepted Answer · 2013-12-06 16:50:20Z

4

You should use this instead.

this[ where ]();

jsFiddle demo

answered Dec 6, 2013 at 16:50

antyrat

27.7k9 gold badges78 silver badges77 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

kasper Taeymans Over a year ago

thank you bro! I did try different combinations but I wasn't clever enough to do it this way! thank you again, it works.

jbabey · Accepted Answer · 2013-12-06 16:54:09Z

You have a few problems:

First, jsFiddle runs all of its code inside an IIFE. Declaring a variable in the javascript section will not append it to the window object of the page.

Second, you can't nest properties via dot notation in bracket notation like that. E.g. ['parent']['child'], not ['parent.child'].

Lastly, you're trying to call an instance method (goHome) on the constructor function, not an instance. You should be using this inside the prototype methods to refer to the instance.

Working example: http://jsfiddle.net/TB8yr/4/

var Controller= function(){
    this.currentpage='home';    
}

Controller.prototype.route=function(where){
    this[where]();
};

Controller.prototype.goHome=function(){
    alert('route gohome');    
}

Controller.prototype.goBack=function(){
    alert('route goback');    
}

test = new Controller();
test.route('goHome');

Collectives™ on Stack Overflow

javascript: call method in an object from string

2 Answers 2

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related