Android query SQLIte syntax error

Question

I receive data from an Activity in which I create a SQL query, but I'm getting syntax error in string. Thanks for help

String sql = "SELECT _Id,Date,cas,N,E,Altro FROM Ge WHERE Ea>0 AND cas LIKE "+c_ricevuta+" AND date LIKE '"+anno_ricevuto+"-%' ORDER BY data DESC";

here syntax error: cas LIKE "+c_ricevuta+"

laalto · Accepted Answer · 2013-12-09 18:50:09Z

1

c_ricevuta should likely be in single quotes '':

String sql = "SELECT _Id,Date,cas,N,E,Altro FROM Ge WHERE Ea>0 AND cas LIKE '"+c_ricevuta+"' AND date LIKE '"+anno_ricevuto+"-%' ORDER BY data DESC";

Note that using string params in your query like this is prone to both syntax errors and SQL injection. Have a look at ? literal placeholders instead, e.g. the selectionArgs in query functions.

answered Dec 9, 2013 at 18:50

laalto

153k68 gold badges293 silver badges306 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Pablo_Cassinerio · Accepted Answer · 2013-12-09 18:52:33Z

0

just in case, I'd place spaces between the word and the "+". Plus, you're not using quotes to surround c_ricevuta

answered Dec 9, 2013 at 18:52

Pablo_Cassinerio

8875 silver badges14 bronze badges

3 Comments

njzk2 Over a year ago

I'd place spaces between the word and the "+". what for?

Pablo_Cassinerio Over a year ago

I've seen some errors pop up because of details like that. Plus it's a good practice to make your code more readable

njzk2 Over a year ago

it's a good practice, yes (but the line's length does come first to mind when looking at this code in terms of readability), but it does not cause error. never.

Collectives™ on Stack Overflow

Android query SQLIte syntax error

2 Answers 2

Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related