Return a random selection from a string using Javascript

Question

I would like a suggestion on why my code isnt working. The idea is to select only three names from a the list of names randomly, but it can't return the same name twice. I think it is close but I'm missing something here. Any help would be appreciated

(function(){

  var randomNames = function(){
      var names = ["Jeffrey, Ronald, Superman, Lyndon, Alison"];
      var myNames = [];

      for (var i = 0; i < 3; i++){
          var newNames = Math.floor(Math.random() * names.length);
          var randomAllNames = names[newNames];
          names.splice(newNames, 1);
          myNames.push(names);
          console.log(myNames);
      }
         return randomAllNames;

  }; randomNames();
})();

Your array contains only one element - a list of names - rather than an element per name. — Mitya
– Mitya, Commented Dec 13, 2013 at 11:51
also you are adding the entire array of names into the myNames array each loop iteration — Slicedpan
– Slicedpan, Commented Dec 13, 2013 at 11:55

milks · Accepted Answer · 2013-12-13 11:56:00Z

1

note the myNames.push(randomAllNames); also your array was just one long string

(function(){

  var randomNames = function(){
      var names = ["Jeffrey", "Ronald", "Superman", "Lyndon", "Alison"];
      var myNames = [];

      for (var i = 0; i < 3; i++){
          var newNames = Math.floor(Math.random() * names.length);
          var randomAllNames = names[newNames];
          names.splice(newNames, 1);
          myNames.push(randomAllNames);
          console.log(myNames);
      }
         return randomAllNames;

  }; randomNames();
})();

answered Dec 13, 2013 at 11:56

milks

3142 silver badges9 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

jmccommas Over a year ago

Ahhh, dumb mistake!! When I console.log(myNames); it returns 3 separate arrays. Amy I returning the wrong variable? ["Alison"] main.js:19 ["Alison", "Ronald"] main.js:19 ["Alison", "Ronald", "Superman"]

milks Over a year ago

yes, the inner function should return myNames and the last line should also be return randomNames() if you want to be able to use the result elsewhere

jmccommas Over a year ago

Yes, as I will be using the results to add to the HTML on the page. Each random name will appear in as a list item

Collectives™ on Stack Overflow

Return a random selection from a string using Javascript

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related