PHP recursive function with array in parameter

Question

i'm trying to get a recursive function working in PHP but it fails with a "Fatal error: Allowed memory size of 134217728 bytes exhausted".

Why isn't this working?

    $atest = array();
    $atest = $this->resolveCategories(3,$atest);
    var_dump($atest);

And the recursive function:

 private function resolveCategories($iCategoryId,$aCategories){
    $oCategory = CategoryQuery::create()->findOneById($iCategoryId);
    if ($oCategory->getParentId() != null){
        array_push($aCategories,$oCategory->getName());
        $this->resolveCategories($iCategoryId,$aCategories);
    }
    return $aCategories;
}

Are you asking for how to lift the memory limit ? or how to improve your algorithm ? — Aysennoussi
– Aysennoussi, Commented Jan 14, 2014 at 19:26
:) No i think the algorithm should determine fast because i only have a few entries in my database. So i think i got an coding error somewhere which i don't find. — J-H
– J-H, Commented Jan 14, 2014 at 19:28
It seems you have possibly triggered an infinite recursion somehow. It is hard to debug this without seeing the actual data being used. Have you treid to debug? Can you identify where the values differ from what is expected? — Mike Brant
– Mike Brant, Commented Jan 14, 2014 at 19:28
what does parent ID return? it seems to always return a value that is not null — Ibu
– Ibu, Commented Jan 14, 2014 at 19:29
How does your function know when to stop? You are just calling the same function with the same parameters over and over. You created an infinite loop. $this->resolveCategories($iCategoryId,$aCategories); Perhaps you wanted to do $this->resolveCategories($iCategoryId-1,$aCategories); or something? — gen_Eric
– gen_Eric, Commented Jan 14, 2014 at 19:32

Sergiu Paraschiv · Accepted Answer · 2014-01-14 19:36:28Z

2

I think you meant to call

$this->resolveCategories($oCategory->getParentId(), $aCategories);

inside, not

$this->resolveCategories($iCategoryId, $aCategories);

answered Jan 14, 2014 at 19:36

Sergiu Paraschiv

10.2k5 gold badges42 silver badges51 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Sergiu Paraschiv Over a year ago

Also, the whole polish notation thing is a bit old. Try meaningful name. $category and $categoryNames reads a lot better.

gen_Eric · Accepted Answer · 2014-01-14 19:35:21Z

1

How does your function know when to stop? You are just calling the same function with the same parameters over and over. You created an infinite loop.

private function resolveCategories($iCategoryId,$aCategories){
    // code...
    $this->resolveCategories($iCategoryId,$aCategories);
    // code...
}

You are never changing the $iCategoryId parameter, so you just keep getting the same row (which happens to have a parent) over and over and over and over.

Perhaps you wanted:

$this->resolveCategories($iCategoryId-1, $aCategories);

or something?

answered Jan 14, 2014 at 19:35

gen_Eric

228k42 gold badges304 silver badges343 bronze badges

Comments

Aysennoussi · Accepted Answer · 2014-01-14 19:29:06Z

0

For recursive functions , you always need a break statement which is generally a IF statement that will return false in on iteration. Generaly you can use a $depth variable and determinate how deep your recursive function can go!

answered Jan 14, 2014 at 19:29

Aysennoussi

3,8804 gold badges42 silver badges63 bronze badges

2 Comments

J-H Over a year ago

i tried an else-part in my if clause. The break point should be if the actual element has no parentId

Aysennoussi Over a year ago

getParentId() is supposed to return object right ? If so use is_object function and do not compare with Null

Mike Brant · Accepted Answer · 2014-01-14 19:30:48Z

0

In general I don't understand how your algorithm is supposed to work. It seems like your array is going to recursively grow in size as you continue to pass the original array (plus item pushed to it to the recursive call.

answered Jan 14, 2014 at 19:30

Mike Brant

71.4k10 gold badges102 silver badges104 bronze badges

1 Comment

J-H Over a year ago

The algorithm is supposed to add all category names to a array. it should end if the actual element has no more parents (parentId == null). Then it should return the generated array.

Collectives™ on Stack Overflow

PHP recursive function with array in parameter

4 Answers 4

1 Comment

Comments

2 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

Comments

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related