PHP loop through folder and echo images in html error

Question

I just can't get this to work what is wrong here?

 $files = scandir('gallery/');
 if ($files !== false) 
 {
    foreach($files as $f) {
      if ($f == '..' || $f == '.')
          continue;     
      echo '<li><img src="gallery/'.$f.'" alt="'.$f.'" title=""></li>'."\n";
    }
 }

the folder is in my root folder named "gallery". The images are inside..

I always get this error:

Warning: Invalid argument supplied for foreach() in "MYDOCUMENT.PHP" on line 101.

can you be more specific, what do i have do to? I'm new to php... — Marc Ster
– Marc Ster, Commented Jan 30, 2014 at 13:32
On the line just below $files = scandir('gallery/'); put var_dump($files); die(); and run the code. Give us the output. — jnthnjns
– jnthnjns, Commented Jan 30, 2014 at 13:33
You might want to consider using glob() . $files = glob('gallery/*.{jpeg,gif,png}', GLOB_BRACE); — Mutale
– Mutale, Commented Jan 30, 2014 at 13:35

Hardik Panseriya · Accepted Answer · 2014-01-30 13:53:00Z

2

<?php
$files = scandir('gallery/');
if ($files !== false) 
{
    foreach(is_array($files) as $f) {
    if ($f == '..' || $f == '.')
?>
    <li><img src="<?php echo 'gallery/'.$f ?>" alt="<?php echo $f ?>" title="">
<?php
   }
} 
?>

answered Jan 30, 2014 at 13:53

Hardik Panseriya

5234 silver badges16 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Sharanya Dutta Over a year ago

How does it work? The function is_array will return true if $files is an array, false otherwise. And how do you iterate over a boolean value with a foreach loop?

MarcoS · Accepted Answer · 2014-01-30 13:39:23Z

2

This works, for me...:

<?php
    $files = scandir('gallery/');
    if ($files !== false) {
        foreach($files as $f) {
            if ($f == '..' || $f == '.') continue;
            echo $f . "<br>\n";
        }
    }
?>

It's quite the same code as yours... So check the "gallery/" directory contents...

answered Jan 30, 2014 at 13:39

MarcoS

17.8k27 gold badges101 silver badges189 bronze badges

5 Comments

Marc Ster Over a year ago

ok this echos the names of the images. how can i echo the images itself?

MarcoS Over a year ago

O.k... Your code prints html which correctly references <src> image tags... So you should check the images are readable by the web server user...

Marc Ster Over a year ago

hm they should be readable, why shouldn't they?Like i said the code prints the names of the images but doesn't display the images

MarcoS Over a year ago

The logic is: PHP code prints HTML with the name of the images. The browser (IE, Firefox, Chrome, ...) which interpets the HTML retrieves the images from the server and displays them...

Marc Ster Over a year ago

i was missing a '/' before the variable.. my bad. it works now thank you very much

ReNiSh AR · Accepted Answer · 2014-01-30 13:37:24Z

1

change foreach to:

 foreach((array)$files as $f)

the code may be:

 $files = scandir('gallery/');
 if ($files !== false) 
 {
    foreach((array)$files as $f) {
      if ($f == '..' || $f == '.')
          continue;     
      echo '<li><img src="gallery/'.$f.'" alt="'.$f.'" title=""></li>'."\n";
    }
 }

edited Jan 30, 2014 at 13:37

answered Jan 30, 2014 at 13:31

ReNiSh AR

2,8623 gold badges34 silver badges43 bronze badges

1 Comment

Marc Ster Over a year ago

didn't change anything

bug · Accepted Answer · 2014-01-30 13:37:36Z

1

You shouldn't validate the array with :

if ($files !== false)

But by doing :

if (is_array($files) && count($files) > 0) {

Or else you'll get warnings like this one.

[EDIT] And consider using glob like one guy said. This will work with that function.

Example:

if (is_array($files) && count($files) > 0) {
   foreach(glob('gallery/*.{jpeg,gif,png}', GLOB_BRACE)) {
      // code here
   }
}

answered Jan 30, 2014 at 13:37

bug

3421 silver badge10 bronze badges

Collectives™ on Stack Overflow

PHP loop through folder and echo images in html error

4 Answers 4

1 Comment

5 Comments

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

5 Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related