Getting syntax error, unexpected end-of-input

Question

I keep getting a syntax error, unexpected end-of-input, despite checking the code, and even after removing the code and running it the problem seems to not be solved.here is the code :

class BookingsController < ApplicationController

before_filter :authenticate_user!

def new
    @booking = Booking.new
end

def create
    @booking = current_user.booking.create(booking_params)
    if @booking.save
        flash[:alert] = "You have now booked a date"
        redirect_to root_path
    else
        flash[:alert] = "Error:booking did not save"
        redirect_to root_path
        render 'new'
    end
end


def show
    @booking = Booking.find(params[:id])
end

def edit
    @booking = Booking.find(params[:id])

    unless @booking.user == current_user
        redirect_to root_path
    end
end

def update 
    @booking = Booking.find(params[:id])
    unless @booking.user == current_user
        redirect_to root_path

    if @booking.update_attributes(booking_params)   
        redirect_to root_path
        flash[:notice] = "You have edited your post"
    else
        render 'edit'
        flash[:alert] = "something went wrong"
    end
end

def destroy 
    @booking = Booking.find(params[:id])
    @booking.destroy
    redirect_to root_path
end 

private
def booking_params
    params.require(:booking).permit(:content)
end

end

Arup Rakshit · Accepted Answer · 2014-02-11 17:19:51Z

2

you missed end keyword here

def update 
    @booking = Booking.find(params[:id])
    unless @booking.user == current_user
        redirect_to root_path
    end # <~~~ missed in your code
    if @booking.update_attributes(booking_params)   
        redirect_to root_path
        flash[:notice] = "You have edited your post"
    else
        render 'edit'
        flash[:alert] = "something went wrong"
    end
end

answered Feb 11, 2014 at 17:19

Arup Rakshit

119k30 gold badges270 silver badges328 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user3150377 Over a year ago

Thank you!! It worked, I thought "unless" would be part of the "if and "else" statement and not need a separate end.

Dave Newton · Accepted Answer · 2014-02-11 17:21:14Z

2

Bogus update method; you're missing an end of the current_user check.

Also redirect does not stop executing code, you need to return.

answered Feb 11, 2014 at 17:21

Dave Newton

161k27 gold badges263 silver badges310 bronze badges

Comments

Arup Rakshit · Accepted Answer · 2014-02-11 17:30:23Z

1

Actual error - missed end after unless condition.

You can even refactor your code like this

def update 
    @booking = Booking.find(params[:id])
    redirect_to root_path unless @booking.user == current_user
    if @booking.update_attributes(booking_params)   
        redirect_to root_path
        flash[:notice] = "You have edited your post"
    else
        render 'edit'
        flash[:alert] = "something went wrong"
    end
end

edited Feb 11, 2014 at 17:30

Arup Rakshit

119k30 gold badges270 silver badges328 bronze badges

answered Feb 11, 2014 at 17:23

Mothirajha

1,0411 gold badge11 silver badges18 bronze badges

Collectives™ on Stack Overflow

Getting syntax error, unexpected end-of-input

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related