php and jquery click event problem

Question

I'm having trouble firing a click event on an . When insertIntoInsertHolder() is called it adds a link to the content of div#swf_insert_holder - I then create the click event just below. However the event doesn't fire.

$javascript = "javascript:;";
$swf_insert_box_link = "swf_insert_box_link";

echo "

function insertIntoInsertHolder( filename ) {   
$('#swf_insert_holder').append('<a href=" . $javascript . " class=" .     $swf_insert_box_link . ">go</a>');
//produces: <a href="javascript:;"    class="swf_insert_box_link">go</a>            
    }

$('a.swf_insert_box_link').click( function() {
alert('hello!!'); //for testing     
});

Thanks in advance!

Could this possibly be because there are numerous syntactical errors in your code? — Tyler Carter
– Tyler Carter, Commented Jan 31, 2010 at 23:44
@Chacha102 Possibly, so a nice answer showing the problems would help more IMO. — Doug Neiner
– Doug Neiner, Commented Jan 31, 2010 at 23:46

Victor Farazdagi · Accepted Answer · 2010-01-31 23:48:45Z

1

It also has to be noted, that event handlers are attached to existing elements. So, when your 'click' event is attached to a.swf_insert_box_link, the element should exist. In order to have event attached to the given existing selector and for any new elements matching the same selector, user live() - http://api.jquery.com/live/

answered Jan 31, 2010 at 23:48

Victor Farazdagi

3,1502 gold badges25 silver badges30 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Doug Neiner · Accepted Answer · 2010-01-31 23:52:29Z

0

Using this will cause it to work:

<?php
$javascript = "javascript:;";
$swf_insert_box_link = "swf_insert_box_link";

echo <<<JS
function insertIntoInsertHolder( filename ) {   
  \$('#swf_insert_holder').append('<a href="$javascript" class="$swf_insert_box_link">go</a>');
  // produces: <a href="javascript:;" class="swf_insert_box_link">go</a>            
}

\$('a.swf_insert_box_link').live('click', function() {
  alert('hello!!'); //for testing     
});
JS;
?>

The important parts were #1, fixing all PHP syntax errors and #2, using live instead of click so you can define the event callback before the element actually exists.

answered Jan 31, 2010 at 23:52

Doug Neiner

66.4k14 gold badges111 silver badges118 bronze badges

2 Comments

Nicholas Reed Over a year ago

when I try <<<JS and close it with JS; I get a syntax at ?> at the last line of the file (its got a lot more stuff in it. If I could use <<<JS that would be godly.

Doug Neiner Over a year ago

@unknown There can be no whitespace (tabs, spaces, etc) between the final JS; and the start of the line. Otherwise it will not know the heredoc ended (The heredoc is the <<<JS ... JS;)

parserr · Accepted Answer · 2010-02-01 00:03:12Z

0

element must exist before attaching event listeners. you can do it with live() function instead of click() (requires jquery 1.3+), or bind it while creating element, like this:

function insertIntoInsertHolder( filename ) {   
    $('#swf_insert_holder').append(
        $('<a>')
            .attr('href', '<?php echo $javascript; ?>')
            .addClass('<?php echo $swf_insert_box_link;?>')
            .text('go')
            .click(function() { alert('hello!!'); });
    );
}

answered Feb 1, 2010 at 0:03

parserr

7291 gold badge5 silver badges15 bronze badges

Collectives™ on Stack Overflow

php and jquery click event problem

3 Answers 3

Comments

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related