Delete row from database using PHP (using a HTML table)

Question

I'm making a "delete" function on my form. I'm not quite happy because it doesn't work! I have tried this code:

     while($row = $result->fetch_assoc())
     {

     $ordernr = $row['ordernr'];
     $klantnaam = $row['klantnaam'];
     $productnaam = $row['productnaam'];
     $productid = $row['productid'];

     echo "<tr>";
     echo "<td width='150px'>" . $ordernr . "</td>";
     echo "<td width='150px'>" . $klantnaam . "</td>";
     echo "<td width='300px'>" . $productnaam . "</td>";
     echo "<td width='100px'>" . $productid . "</td>";

     echo "<td align='center' width='50px'><input name='delete[$ordernr]' type='checkbox'></td>";

     echo "</tr>";
     }

     echo "<tr>";

     echo "<td><input type='submit' name='verwijderen' value='Verwijderen'/></td>";
     echo "</tr>";
     echo "</table>";
     echo "</form>";

     $delete = $_POST['delete'];

     if (isset($_POST['verwijderen'])) {
         foreach($delete as $ordernr => $delete)
         {
             $ordernr = mysqli_real_escape_string($ordernr);
             $query = mysqli_query("DELETE FROM overzicht WHERE ordernr= $ordernr");
         }
     }

Do you guys know what I've done wrong?

Thanks in advance!

Have you checked that your $ordernr is being passed back? put an echo in your for loop and that echo's out the sql — andrew slaughter
– andrew slaughter, Commented Feb 25, 2014 at 11:01
delete[$ordernr] perhaps the issue. You can use delete[] with a value as $ordernr and on POST part u get an array and using the loop you can delete the items which are checked !! — Abhik Chakraborty
– Abhik Chakraborty, Commented Feb 25, 2014 at 11:01
judging by the responses here... I'd say it's hard to pinpoint just one problem. I'm surprised there are no parse errors! — Spork
– Spork, Commented Feb 25, 2014 at 11:09

Pian0_M4n · Accepted Answer · 2014-02-25 11:02:16Z

1

1)

echo "<td align='center' width='50px'><input name='delete[$ordernr]' type='checkbox'></td>";

transforms to

echo "<td align='center' width='50px'><input name='delete' type='checkbox' value='$ordernr'></td>";

2)

foreach($delete as $ordernr => $delete)
do it:
foreach($delete as $ordernr => $del)

you are overwriting the $_POST

answered Feb 25, 2014 at 11:02

Pian0_M4n

2,56836 silver badges35 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Levialhan Over a year ago

Do I have to define $del somewhere? (because I actually haven't)

Pian0_M4n Over a year ago

that was a comment so you know you have to change it. when you use $delete a second time it replaces the original one that comes from $_POST

Deepu Sasidharan · Accepted Answer · 2014-02-25 11:03:02Z

0

mysqli_query syntaxt is

mysqli_query($con,"your query");

answered Feb 25, 2014 at 11:03

Deepu Sasidharan

5,32911 gold badges46 silver badges100 bronze badges

Comments

dkasipovic · Accepted Answer · 2014-02-25 11:03:51Z

0

I'd go and say that your input checkbox needs a value. Like

<input type="checkbox" name="delete[1]" value="1" />

On the other hand, then it would be easier to have

<input type="checkbox" name="delete[]" value="$ordernr" />

And then you loop with

foreach ($_POST["delete"] as $id) delete(id)

answered Feb 25, 2014 at 11:03

dkasipovic

6,1301 gold badge23 silver badges27 bronze badges

Comments

Mani · Accepted Answer · 2014-02-25 11:04:59Z

0

where con variable in your query...

$query = mysqli_query($con,"DELETE FROM overzicht WHERE ordernr= $ordernr");

answered Feb 25, 2014 at 11:04

Mani

8886 silver badges19 bronze badges

1 Comment

Levialhan Over a year ago

Yes, you're right. I've forgotten to put $con there. My bad!

Spork · Accepted Answer · 2014-02-25 11:08:07Z

0

You're iterating while reusing your variable here:

foreach($delete as $ordernr => $delete)

Where the second $delete will overwrite the value of the first, and throw a spanner in the works.

I suggest to rename the prior instances of $delete to $deleteList and do:

foreach($deleteList as $ordernr => $delete)

Keep in mind that much of your code could be done in different ways that may be more suitable. You will find those as you follow your path in learning PHP.

edited Feb 25, 2014 at 11:08

answered Feb 25, 2014 at 11:01

Spork

1,6311 gold badge23 silver badges39 bronze badges

Collectives™ on Stack Overflow

Delete row from database using PHP (using a HTML table)

5 Answers 5

2 Comments

Comments

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

2 Comments

Comments

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related