javaScript: Add a default error callback

Question

I have a written a function which in turn makes ajax calls. I have used this in all my pages.

    function getFunc(fullURL, successCallback, errorCallback) {
        $.ajax({
            type : 'GET',
            url : fullURL,
            async : false,
            dataType : 'json',
            success : successCallback,
            error : errorcallback   

      });
    }

And call this function as follows-

getFunc(someurl,
            function(data){
                //display data
             },
          function(xhr, textStatus, errorThrown){
                //display errors
           }
 );

This code works fine. Now I have to add some default error handling code which is for all the web pages which call getFunc(..), but I dont want to go into each web page and do it. how can I do that in getFunc(..)?

i.e I need a way to do this-

function getFunc(fullURL, successCallback, errorCallback) {
            $.ajax({
                type : 'GET',
                url : fullURL,
                async : false,
                dataType : 'json',
                success : successCallback,
                error : do some default error handling and then call errorCallback  

          });
        }

If I'm understanding this right, you need to handle errors that getFunc will throw? What is getFunc throwing? — ToastyMallows
– ToastyMallows, Commented Mar 3, 2014 at 17:22
Why are you using async: false? This will lock up the entire browser until the call is completed. — gen_Eric
– gen_Eric, Commented Mar 3, 2014 at 17:24
That was a typo. In my actual code its async:true. Thanks for pointing it out — Abhishek Amte
– Abhishek Amte, Commented Mar 3, 2014 at 17:31
@AbhishekAmte: Just get rid of the async option altogether. It's not needed. — gen_Eric
– gen_Eric, Commented Mar 3, 2014 at 17:33

gen_Eric · Accepted Answer · 2014-03-03 17:23:26Z

3

Why not pass an anonymous function to error instead of errorcallback. Have the function do stuff then call errorcallback when it's done.

function getFunc(fullURL, successCallback, errorCallback) {
    $.ajax({
        type: 'GET',
        url: fullURL,
        async: false,
        dataType: 'json',
        success: successCallback,
        error: function(xhr, textStatus, errorThrown){
            // Do whatever
            // ...

            // Then call errorCallback
            errorCallback.apply(this, arguments);
        }
    });
}

answered Mar 3, 2014 at 17:23

gen_Eric

228k42 gold badges304 silver badges343 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

JF it · Accepted Answer · 2014-03-03 17:25:01Z

0

I think what you mean to say is, if the error is unhandled by the caller - i.e. they don't specify a function..

Change your getFunc to this:

function getFunc(fullURL, successCallback, errorCallback) {
    $.ajax({
        type : 'GET',
        url : fullURL,
        async : false,
        dataType : 'json',
        success : successCallback,
        error : function(error) { 
             if(errorcallback)
                errorcallback(error.xhr...etc...);
             else
                catchUnhandled(error);
        }

    });
}
function catchUnhandled (error)
{   //place catch all code here }

answered Mar 3, 2014 at 17:25

JF it

2,3833 gold badges23 silver badges30 bronze badges

Collectives™ on Stack Overflow

javaScript: Add a default error callback

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related