Creating a csv file, not adding to the next column

Question

First time trying to build a csv file in c#, here is the code:

string FilePath = @"C:\Users\me\Downloads\csvfiles\test-" + DateTime.Now.ToString("dd-MM-yyyy-hh-mm-ss") + ".csv";
string delimit = ",";
List<string> cells = new List<string>();

Console.WriteLine("Gathering the data...");

SqlConnection con = new SqlConnection(Properties.Settings.Default.ConnectionString);
con.Open();
SqlCommand cmd = new SqlCommand();
cmd.Connection = con;
cmd.CommandType = System.Data.CommandType.Text;
cmd.CommandText = "SELECT id, name FROM contacts";

SqlDataReader reader = cmd.ExecuteReader();

Console.WriteLine("Building the csv file");

while (reader.Read())
{
    AddCell((IDataRecord)reader, cells);
}

StringBuilder sb = new StringBuilder();

for (int i = 0; i < cells.Count; i++)
{
    sb.AppendLine(string.Join(delimit, cells[i]));
}

File.WriteAllText(FilePath, sb.ToString());

/*Method to add each record to the list*/
public static void AddCell(IDataRecord record, List<string> cells)
{
    cells.Add(record[0].ToString());
    cells.Add(record[1].ToString());
}

Trouble is, it appends everything to a new row, it doesn't move record[1] to the next column and start a new row...

Please, do not include information about a language used in a question title unless it wouldn't make sense without it. Tags serve this purpose. — Ondrej Janacek
– Ondrej Janacek, Commented Mar 6, 2014 at 12:26
I am joining by the delimit variable, which is why it is moving to the next row... — user2405469
– user2405469, Commented Mar 6, 2014 at 12:33
If you discovered a solution to your problem, post it as an answer, please. Or delete your question completely. — Ondrej Janacek
– Ondrej Janacek, Commented Mar 6, 2014 at 12:45

cvraman · Accepted Answer · 2014-03-06 12:47:48Z

1

Your For loop is incorrect for what you are trying to do.

Replace :

    for (int i = 0; i < cells.Count; i++)
    {
         sb.AppendLine(string.Join(delimit, cells[i]));
    }

With

    int i = 0;
    while (i < cells.Count)
    {
       sb.AppendLine(string.Join(delimit, cells[i],cells[i+1]));
       i = i + 2;
    }

answered Mar 6, 2014 at 12:47

cvraman

1,6871 gold badge12 silver badges18 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

cvraman Over a year ago

@user2405469 : If this solved your problem, please mark it as answer.

user2405469 · Accepted Answer · 2014-03-06 12:53:27Z

string FilePath = @"C:\Users\me\Downloads\csvfiles\test-" + DateTime.Now.ToString("dd-MM-yyyy-hh-mm-ss") + ".csv";
string delimit = ",";
List<string> cells = new List<string>();

Console.WriteLine("Gathering the data...");

SqlConnection con = new SqlConnection(Properties.Settings.Default.ConnectionString);
con.Open();
SqlCommand cmd = new SqlCommand();
cmd.Connection = con;
cmd.CommandType = System.Data.CommandType.Text;
cmd.CommandText = "SELECT id, name FROM contacts";

SqlDataReader reader = cmd.ExecuteReader();

Console.WriteLine("Building the csv file");

while (reader.Read())
{
    AddCell((IDataRecord)reader, cells);
}

StringBuilder sb = new StringBuilder();

for (int i = 0; i < cells.Count; i++)
{
    if (cells[i].Equals("\n"))
    {
        sb.Append(Environment.NewLine);
    }
    else
    {
        sb.Append(cells[i]);
    }
}

File.WriteAllText(FilePath, sb.ToString());

/*Method to add each record to the list*/
public static void AddCell(IDataRecord record, List<string> cells)
{
    cells.Add(record[0].ToString());
    cells.Add(",");
    cells.Add(record[1].ToString());
    cells.Add("\n");
}

not as elegant as yours @cvraman but it worked too :) I will be using your solution.

Collectives™ on Stack Overflow

Creating a csv file, not adding to the next column

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related