AngularJS : Factory Service Controller $http.get

Question

I am trying to retrieve the "cart" in the following way Factory->Service->Controller. I am making an $http call but it is returning an object. If I debug I can see that the request is made and is retrieving the data (in the network section of the debugger).

angular.module('companyServices', [])
.factory('CompanyFactory', ['$http', function($http){
    return {
        getCart: function(cartId) {
            var promise = $http.get('company/Compare.json', {params: {'wsid': cartId}})
             success(function(data, status, headers, config) {
                return data;
            }).
            error(function(data, status, headers, config) {
                return "error: " + status;
            });
        }
    };
}]);

angular.module('itemsServices', [])
.service('ItemsServices', ['CompanyFactory', function(CompanyFactory){
    var cartId = new Object();
    this.getCartId = function(){
        return cartId;
    };
    this.cartId = function(value){
        cartId = value;
    };
    this.getCart = function(){
      return CompanyFactory.getCart(this.getCartId()).then(function(data){return data});
    };
};

.controller('CompareItemsCtrl', ['$scope', '$location', 'ItemsServices', function($scope, $location, ItemsServices){
  var params = $location.search().wsid;
  ItemsServices.cartId(params);
  console.log('ItemsServices.getCart()');
  console.log(ItemsServices.getCart());
};

Thank you

so what's the problem then? You get a response, what's wrong with it?fwiw, I think you would want to pass in success and error handlers to getCart. getCart().then(successFunction, errorFunction) — thescientist
– thescientist, Commented Mar 25, 2014 at 3:33

thescientist · Accepted Answer · 2014-03-25 03:37:58Z

2

Since $http returns a promise, I think you would be better of passing in your success and error functions to getCart()

.controller('CompareItemsCtrl', ['$scope', '$location', 'ItemsServices', function($scope, $location, ItemsServices){
  var params = $location.search().wsid;
  ItemsServices.cartId(params);
  console.log('ItemsServices.getCart()');
  console.log(ItemsServices.getCart());
  ItemsService.getCart().then(function(response){
    console.log('success');
  },function(response){
    console.log('error');
  });
};

answered Mar 25, 2014 at 3:37

thescientist

2,9581 gold badge21 silver badges15 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

AngularJS : Factory Service Controller $http.get

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related