Using Hashsets to Count Amount of Strings in Array without Duplicates

Question

I am trying to use a hashset to count the amount of strings in a string array without counting duplicates. However, this program is not working correctly. For eg. this code prints out "4", when in truth their are only 3 unique strings. Does anyone know why this is working incorrectly?

    String centers[]=new String[1000];


    /* Only for Testing Purposes*/
    centers[0] = "Soccer";
    centers[1] = "Soccer";
    centers[2]=  "Baseball";
    centers[3] = "Table Tennis";
    centers[4] = "Soccer";


    List<String> centerList = Arrays.asList(centers);
    Set<String> uniqueCenters = new HashSet<String>();
    uniqueCenters.addAll(centerList);
    Integer numberOfUniqueStrings = uniqueCenters.size();

    System.out.println(numberOfUniqueStrings);

Brendan Long · Accepted Answer · 2014-04-28 00:01:56Z

6

Just a guess, but centers has 1000 elements, and you only set 5 of them. Maybe the other 995 are null, giving you a HashSet with one more element than you expect (null).

You can easily test this by printing the contents though:

for (String s : uniqueCenters) {
    System.out.println("Got element: " + s);
}

answered Apr 28, 2014 at 0:01

Brendan Long

54.5k21 gold badges154 silver badges194 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Radiodef Over a year ago

Or just print the Set: [null, Table Tennis, Soccer, Baseball]. And indeed this is the case since HashSet allows null.

josephus · Accepted Answer · 2014-04-28 00:21:39Z

1

The problem is with this statement:

String centers[]=new String[1000];

You're creating a String array with 1000 elements. In java, instantiating an array also assigns a default value to the elements of the array, in this case, the elements all have a null value.

That's why when you create a HashSet of that array, you're essentially getting "Soccer", "Baseball", "Table Tennis", and null.

edit:

You can remove the null entry in your HashSet by calling uniqueCenters.remove(null);

edited Apr 28, 2014 at 0:21

answered Apr 28, 2014 at 0:04

josephus

8,3041 gold badge40 silver badges58 bronze badges

1 Comment

mortsahl Over a year ago

This is pretty awful looking code however the reason given is correct. A Set, by definition, will not allow duplicates, however it will allow (one and only one) null. Therefore the output value is correct.

Collectives™ on Stack Overflow

Using Hashsets to Count Amount of Strings in Array without Duplicates

2 Answers 2

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related