php - Can't delete input in table using sql statement

Question

I don't know what I have done to this but I had the form working and now it has stopped. My problems are with the bottom if statement where I am trying to delete the user. As I said it was working properly and now it has stopped. I just can't figure out what the issue is? And yes I do backup but clearly should do it more!

function HMdisplayrooms() {
    global $wpdb;
    echo '<html><body><h1>Display Rooms</h1>';
    echo '<p>Order room view by: <p>
    <form name = "view_HM_rooms" method="post" action="">
            <select name="roomsView" size = "1">
                <option value = "room_id">Room ID</option>
                <option value = "room_type">Room Type</option>
            </select></br>
            <input type="submit" name="action">
    </form></body></html>';
    echo '<table border="1" style="width:1000px" cellspacing ="0"><tr><td><b>Room      ID</b></td><td><b>Room Type</b></td><td><b>Options</b></td></tr>';
    if(isset($_POST['action'])) {
        $roomType = $_POST['roomsView'];
        $query = "SELECT * FROM hm_room ORDER BY $roomType ASC";
        $rooms = $wpdb->get_results($query);

        foreach ($rooms as $room) {
            $roomID = ($room->room_id);
            echo '<tr><td>'.format_to_post($room->room_id).'</td><td>'.format_to_post($room->room_type).'</td><td><form name = "HotelManiaRoomDeletion" method="post" action="">
            <input type="submit" name="action2" value="Delete Room"></form></td></tr>';

            if(isset($_POST['action2'])){
                $results = $wpdb->query("DELETE FROM hm_room WHERE room_id='".$roomID."'");
                $msg = "Room deleted";  
                return $msg;
            }
        }       
    }
}

You have your form and delete query set inside a foreach loop. You sure you want to do that? — Funk Forty Niner
– Funk Forty Niner, Commented May 28, 2014 at 3:50
can you post the error or warning msg. If any thing is coming. — Chittaranjan Sethi
– Chittaranjan Sethi, Commented May 28, 2014 at 3:52
I don't know php and am not a very good coder, only just started. I was simply making a table using php and it needed a form by it. I just want to delete the room that has the associated delete submit button. It was working, but I don't know how I broke it. — Danrex
– Danrex, Commented May 28, 2014 at 3:53
when you click Delete Room $_POST['action2'] will be set , but $_POST['action'] will be null that time. Try checking that. @Fred-ii- you are right, the block should be made stand alone — shatheesh
– shatheesh, Commented May 28, 2014 at 3:53

shatheesh · Accepted Answer · 2014-05-28 04:00:49Z

2

Use the code like this,

function HMdisplayrooms() {
    global $wpdb;
    echo '<html><body><h1>Display Rooms</h1>';
    echo '<p>Order room view by: <p>
    <form name = "view_HM_rooms" method="post" action="">
            <select name="roomsView" size = "1">
                <option value = "room_id">Room ID</option>
                <option value = "room_type">Room Type</option>
            </select></br>
            <input type="submit" name="action">
    </form></body></html>';
    echo '<table border="1" style="width:1000px" cellspacing ="0"><tr><td><b>Room      ID</b></td><td><b>Room Type</b></td><td><b>Options</b></td></tr>';
    if(isset($_POST['action'])) {
        $roomType = $_POST['roomsView'];
        $query = "SELECT * FROM hm_room ORDER BY $roomType ASC";
        $rooms = $wpdb->get_results($query);

        foreach ($rooms as $room) {
            $roomID = ($room->room_id);
            echo '<tr><td>'.format_to_post($room->room_id).'</td><td>'.format_to_post($room->room_type).'</td><td><form name = "HotelManiaRoomDeletion" method="post" action="">
            <input type="hidden" name="DelRooMId" value="'.$roomID.'">
            <input type="submit" name="action2" value="Delete Room"></form></td></tr>';


        }       
    }

     if(isset($_POST['action2'])){
                $roomID = $_POST['DelRooMId']; // sanitize the input
                $results = $wpdb->query("DELETE FROM hm_room WHERE room_id='".$roomID."'");
                $msg = "Room deleted";  
                return $msg;
     }
}

I have pulled the DELETE block outside of your code. It may help you. The problem with your code is $_POST['action'] will be null at the time of DELETE operation , so the code never executes, that may be the error

Note - Make sure to get the $roomID when you are using the below structure

answered May 28, 2014 at 4:00

shatheesh

6336 silver badges10 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Danrex Over a year ago

I know what your saying but it was working so that is why I know I had it right.

shatheesh Over a year ago

Made some edits to the initial code, compare it with yours, may help you

Danrex Over a year ago

OMG thank you. I don't know what I did before to make it work before, but this is much more elegant. I did not know about the hidden code.

shatheesh Over a year ago

I was glad to be able to help you. :-)

Collectives™ on Stack Overflow

php - Can't delete input in table using sql statement

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related