PHP: reusing database class

Question

I built a class that allows me to do:

$db->query($query);

and it works perfectly, although if I want to do:

$db->query($query);
while($row = $db->fetch_assoc()){
    $db->query($anotherquery);
    echo $db->result();
}

it "breaks" the class. I don't want to constantly have to redeclare my class (eg: $seconddb = new database()), is there a way to get around this? I want to be able to reuse $db within $db, without overwriting the "outside" db. currently I'm create an array of data (from db->fetch_assoc() then doing a foreach and then doing the db call inside that:

$db->query('SELECT * FROM table');
while($row = $db->fetch_assoc()){
    $arr[] = $row;
}

foreach($arr as $a){
    $db->query(); // query and processing here
}

Is this the best method or am I missing the obvious? Should I consider passing a connection link ID with the database connection?

Just curious, would it be good to you if you used ADOdb library? adodb.sourceforge.net — Nirmal
– Nirmal, Commented Mar 8, 2010 at 0:07

Ignacio Vazquez-Abrams · Accepted Answer · 2010-03-08 00:00:49Z

2

Have $db->query() return a "query" object which you can then iterate for the query results.

answered Mar 8, 2010 at 0:00

Ignacio Vazquez-Abrams

804k160 gold badges1.4k silver badges1.4k bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Vidar Vestnes · Accepted Answer · 2010-03-08 00:07:26Z

1

You should consider having the $db->query() method return a result so you don't need to save the states in the result.

Ex.

// psaudo
class DB{

  function query($sql){
    $db->query('SELECT * FROM table');
    $arr = array();
    while($row = $db->fetch_assoc()){
      $arr[] = $row;
    }
    return $arr;
  }

}

But the way, having a nested query loop like your example may be very slow and not scale up.

answered Mar 8, 2010 at 0:07

Vidar Vestnes

43k30 gold badges89 silver badges100 bronze badges

Comments

Michael D. Irizarry · Accepted Answer · 2010-03-08 00:08:03Z

1

You should use

$query = $this->db->query("YOUR QUERY");

foreach ($query->result_array() as $row)
{
   echo $row['title'];
   echo $row['name'];
   echo $row['body'];
}

answered Mar 8, 2010 at 0:08

Michael D. Irizarry

6,3825 gold badges33 silver badges35 bronze badges

Collectives™ on Stack Overflow

PHP: reusing database class

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related