python dynamic input, update table

Question

I wrote a program in order to dynamically update a database table but I am getting an error. I stuffed the program with whatever I know little about. Here's my code:

import MySQLdb
class data:
    def __init__(self):
        self.file123 = raw_input("Enter film: ")
        self.title_ = raw_input("Enter film: ")
        self.year = raw_input("Enter year: ")
        self.director = raw_input("Enter director: ")
a=data()

db = MySQLdb.connect(host="localhost", # your host, usually localhost
                     user="root", # your username
                      passwd="mysql", # your password
                      db="sakila") # name of the data base

cursor = db.cursor()

cursor.execute("INSERT INTO films (file123, title_, year, director) VALUES (?, ?, ?, ?)", (a.file123, a.title_, a.year, a.director))
db.commit()
db.close()

This is the error:

File "C:\Python27\maybe1.py", line 20, in <module>
 cursor.execute("INSERT INTO films (file123, title_, year, director) VALUES (?, ?, ?, ?)", (a.file123, a.title_, a.year, a.director))
      File "C:\Python27\lib\site-packages\MySQLdb\cursors.py", line 184, in execute
        query = query % db.literal(args)
    TypeError: not all arguments converted during string formatting

How can I fix this issue ?

Use %s instead of ?.

WKPlus
– WKPlus

2014-06-25 08:55:46 +00:00
Commented Jun 25, 2014 at 8:55 — WKPlus
– WKPlus, Commented Jun 25, 2014 at 8:55

Community · Accepted Answer · 2017-05-23 12:20:44Z

1

You should change ? to %s.

Here is question about why mysqldb use %s instead of ?.

edited May 23, 2017 at 12:20

CommunityBot

11 silver badge

answered Jun 25, 2014 at 8:55

WKPlus

7,3152 gold badges38 silver badges55 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

adarshram Over a year ago

i still get error as : OperationalError: (1366, "Incorrect integer value: 'a' for column 'file123' at row 1")

WKPlus Over a year ago

It's a mysql error: 'a' is not integer type, but you are trying to insert it into an integer field.

adarshram Over a year ago

how to specifically define datatype for each field,could u provide me any example link please..which will be also helpful?

WKPlus Over a year ago

CREATE TABLE test (id INT) creates a table with one field named id whose type is INT.

adarshram Over a year ago

if i need a string ,what should i do from the above example to enter string?

|

Konark Modi · Accepted Answer · 2014-06-25 09:03:34Z

1

I would do it this way:

query = "INSERT INTO films (file123, title_, year, director) VALUES (%s, %s, %s, %s)" % (a.file123, a.title_, a.year, a.director)

cursor.execute(query)

Replace %s with correct data type, else it will try everything as string which might break at table level.

answered Jun 25, 2014 at 9:03

Konark Modi

7496 silver badges8 bronze badges

2 Comments

WKPlus Over a year ago

It's not a safe way to concatenate parameter like this.

adarshram Over a year ago

why do you say its not safe?

Collectives™ on Stack Overflow

python dynamic input, update table

2 Answers 2

7 Comments

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

7 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related