Perl open file with variable in name

Question

Why is this example not working?

#!/usr/bin/perl
use POSIX qw(strftime);
use Time::Local;

my $date = strftime "%Y-%m-%d", localtime;
my $command = "ls clients/*/ERRORi/" . $date . "/*s";

@result = `$command`;

foreach $group (@result) {
  my $file = '/opt/' . $group;
  open( my $input_fh, '<', $file) || die "Can't open $file: $!";
  print $input_fh;
}

it will return:

Can't open /opt/clients/cli8832/ERRORi/2014-06-25/file.564159972s
: No such file or directory at ./my.pl line 12.

but if I do ls /opt/clients/cli8832/ERRORi/2014-06-25/file.564159972s it works

The formatting of the error message is a good clue here. Your $file has a newline in it. — friedo
– friedo, Commented Jun 26, 2014 at 12:46

JB. · Accepted Answer · 2014-06-26 12:44:51Z

8

Your $file variable contains a trailing linefeed character, whereas your actual file name doesn't.

Your ought to chomp it out.

answered Jun 26, 2014 at 12:44

JB.

42.5k13 gold badges83 silver badges109 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Miller · Accepted Answer · 2014-06-26 19:42:13Z

2

That's a poor example to be learning from.

Include use strict; and use warnings in EVERY perl script.
Include use autodie; anytime you're doing file processing
And finally, instead of shelling out to ls, just use a file glob. This will remove the need to chomp.

Then following is a cleaned up version of that example, although the last line is probably also a bug.

#!/usr/bin/perl
use strict;
use warnings;
use autodie;

use POSIX qw(strftime);
use Time::Local;

my $date = strftime "%Y-%m-%d", localtime;

for my $group (glob "clients/*/ERRORi/$date/*s") {
    my $file = '/opt/' . $group;
    open my $input_fh, '<', $file;
    print $input_fh;
}

edited Jun 26, 2014 at 19:42

answered Jun 26, 2014 at 18:19

Miller

35.3k4 gold badges42 silver badges61 bronze badges

Collectives™ on Stack Overflow

Perl open file with variable in name

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related