C++ Segmentation Fault user input in an array

Question

can somebody say me what im missing?

int main() {
char eingabe[100];
cin >> eingabe;
eingabe[strlen(eingabe)]='\0';
cout << eingabe << endl;
}

But i get this: Segmentation fault

:(

Remove this unnecessary line: eingabe[strlen(eingabe)]='\0'; — πάντα ῥεῖ
– πάντα ῥεῖ, Commented Jun 28, 2014 at 11:41
Please just think about eingabe[strlen(eingabe)]='\0' for a minute. — Kerrek SB
– Kerrek SB, Commented Jun 28, 2014 at 11:42
You know that by-definition of a null char terminated string, s[strlen(s)] is already 0, right? How do you think strlen() managed to determine its return value? And to answer the question, std::string is what you're missing. — WhozCraig
– WhozCraig, Commented Jun 28, 2014 at 11:42
Just use std::string and safe yourself the trouble. Your program will break if the input is more than 99 chars long. — Baum mit Augen
– Baum mit Augen ♦, Commented Jun 28, 2014 at 11:45

Jakub · Accepted Answer · 2014-06-28 12:07:56Z

5

If cin contains a line longer then 99 characters, the cin >> operator writes beyond the eingabe[] buffer end. This is wrong and likely to generate the segfault.

You may want to use the std::string class, rather then a char[] buffer.

If you have some good reason to use a char[100] buffer, then cin.getline(eingabe,100) is what you need.

edited Jun 28, 2014 at 12:07

answered Jun 28, 2014 at 11:49

Jakub

5733 silver badges8 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

C++ Segmentation Fault user input in an array

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related