PHP - return value from recursive function

Question

I have function like this:

function show_comments(&$comments, $parent_id = 0) {
      $comments_list = "<ul>\n";
      foreach($comments as $comment) :
        if ($comment["parent_id"] != $parent_id)
          continue;
        $comments_list .= "<li>\n<h2>{$comment['id_comment']}</h2>\n";
        $comments_list .= "<p>$comment[body]</p>\n";


        $this->show_comments($comments, $comment['id_comment']);
        $comments_list .= "</li>\n";
      endforeach;
      $comments_list .= "</ul>\n";

      return $comments_list;
    }

At the moment this function is returning only one result (the first one). How can I bind all result and return them?

It should return all comments. Are you sure in $comments you have more than 1 comment and those comments' parent_id are different that $parent_id passed as parameter (or 0 if none given)? — Marcin Nabiałek
– Marcin Nabiałek, Commented Jul 2, 2014 at 9:00
There are 5 comments at the moment. First comment is the parent (with parent_id = 0), and next comment is the child of the previous one (comment 2 is child of comment 1, comment 3 is child of comment 2 and so on). — Sasha
– Sasha, Commented Jul 2, 2014 at 9:02

fdehanne · Accepted Answer · 2014-07-02 09:03:57Z

2

On line 10, you call show_comments() but you don't concatenate result.

$comments_list .= $this->show_comments($comments, $comment['id_comment']);

answered Jul 2, 2014 at 9:03

fdehanne

1,7281 gold badge18 silver badges32 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Sasha Over a year ago

Thanks a lot mate, you saved me from headache. It works like a charm :) (I was trying to solve this for more than an hour :D ).

Collectives™ on Stack Overflow

PHP - return value from recursive function

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related