Separating Javascript functions

Question

I am wondering how javascripts get included in a jsp - can we put any code which the jsp will recognize and not just javascript code only in the .js file?

I have some common javascript code which needs to get executed on different pages, so I decided to place it in its own separate .js file and include it on all jsps which call that function.

The js function now refers to a key from a properties file and some other non-javascript code:

function openPrivacyStmntWindow(){
var url = <h:outputText escape="false" value="\"#{urls.url_privacyStatement}\";" />
newwindow=window.open(url,'Terms','height=600,width=800,left=300,top=100,scrollbars=1');
newwindow.focus();
return false;

}

This function worked just fine when it was included in the jsp itself. Now that I have separated it into its own file it doesnt, do I need to include the properties bundle in this file.

The value="\"#{urls.url_privacyStatement}\";" is referring to a bundle called "urls" which has a key called "url_privacyStatement"

Also in Line 1 var url = <h:outputText escape="false" value="\"#{urls.url_privacyStatement}\";" /> the <h:outputText escape="false" ... /> will it cause any issues?

Thanks.

You should escape anything you put in a value attribute.

Justin Johnson
– Justin Johnson

2010-03-19 17:43:23 +00:00
Commented Mar 19, 2010 at 17:43 — Justin Johnson
– Justin Johnson, Commented Mar 19, 2010 at 17:43

T.J. Crowder · Accepted Answer · 2010-03-19 17:06:31Z

2

You can't use custom tags in your js files. But you can extract this to a separate jsp page and include it in all the pages. You can also set the contentType for that jsp to be text/javascript.

edited Mar 19, 2010 at 17:06

T.J. Crowder

1.1m201 gold badges2k silver badges2k bronze badges

answered Mar 19, 2010 at 17:00

Teja Kantamneni

17.5k12 gold badges58 silver badges86 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

T.J. Crowder Over a year ago

Re contentType: can and really should.

msharma Over a year ago

This works beautifully! I placed my js function in a jsp page with content only javascript. A very smart way of getting around the problem, many thanks. :-)

Collectives™ on Stack Overflow

Separating Javascript functions

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related