Javascript Function Variable

Question

Can someone please help me fix this function? It will work if I change the two variables to integers (ie: '987') but if I change them to a character value like 'test' it won't search the array.

I'm new to javascript so excuse me if this is an easy fix. Thank you in advance.

var myArray = [{
  'Vendor': '123',
  'Item': '987',
  'ID': '1'
}, {
  'Vendor': '123',
  'Item': '654',
  'ID': '2'
}];

function findById(source, Vendor, Item) {
  return source.filter(function(obj) {
    return +obj.Vendor === +Vendor, +obj.Item === +Item;
  })[0];
}
var vendin = '123';
var prodin = '654';
var result = findById(myArray, vendin, prodin);
console.log(result.ID);

The variables in question are vendin and prodin.

I'm confused by the comma in your return statement. Didn't you mean to use return +obj.Vendor === +Vendor && +obj.Item === +Item; ? — Ian
– Ian, Commented Jul 22, 2014 at 19:45

Patrick Evans · Accepted Answer · 2014-07-22 19:46:20Z

1

Your return statement is wrong, it is only going to return whatever the last statement results in: +obj.Item === +Item, you need to use a logical operator &&,|| between the statements not a comma

return +obj.Vendor === +Vendor, +obj.Item === +Item;

should be

return (+obj.Vendor === +Vendor) && (+obj.Item === +Item);

Also remove the + if testing strings

answered Jul 22, 2014 at 19:46

Patrick Evans

42.8k6 gold badges81 silver badges94 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Mauriel · Accepted Answer · 2014-07-22 20:14:22Z

0

Try this:

var myArray = [{'Vendor': '123','Item':'987','ID':'1'}, {'Vendor': '123','Item':'654','ID':'2'}, {'Vendor': "test",'Item':"test2",'ID':'3'}];

function findById(source, Vendor, Item) {

    var x = source.filter(function( obj ) {
        return (obj.Vendor == Vendor && obj.Item == Item);
    })[ 0 ];
    return x;
}

var vendin = "test";
var prodin = "test2";
var result = findById( myArray,vendin,prodin)

console.log(
result.ID
);

answered Jul 22, 2014 at 20:14

Mauriel

364 bronze badges

Collectives™ on Stack Overflow

Javascript Function Variable

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related