regexp javascript in angularjs filter

Question

This is my angularjs filter :

app.filter('cleanit', function() {
    return function (input) {
        input = input.replace(new RegExp('&#xe9;'),'é');
        input = input.replace(new RegExp('&#xc9;'),'É');
        input = input.replace(new RegExp('&#xd4;'),'Ô');
        input = input.replace(new RegExp('&#039;'), '\'');
        return input;
    }
});

I use it for replace bad accents in feeds parsed with Google Feed API. It's works good but it's only works once per item, the replacement no longer takes place then, after the first success. what's wrong ?

You need to add the g modifier to your RegExps to make it global. You can also do this using /regex/g syntax instead of using the new RegExp() constructor because your regexes are statically defined. — RevanProdigalKnight
– RevanProdigalKnight, Commented Aug 28, 2014 at 13:19
Actually now that I think about it, why are you even using RegExp for your replace? If you just pass a string as the first argument, it automatically uses a global replace, and you're not replacing anything that requires a regex. — RevanProdigalKnight
– RevanProdigalKnight, Commented Aug 28, 2014 at 13:26

falsetru · Accepted Answer · 2014-08-28 13:33:08Z

4

As RevanProdigalKnight commented, you need to specify g modifier to globally replace matches:

input = input.replace(new RegExp('&#xe9;', 'g'), 'é');

input = input.replace(/&#xe9;/g, 'é');

BTW, here's a different way to solve your problem (instead of specifying charref, using replacement function.)

input = input.replace(/&#x([a-f0-9]+);/ig, function($0, $1) {
    // The return value is used as a replacement string
    return String.fromCharCode(parseInt($1, 16));
});

answered Aug 28, 2014 at 13:33

falsetru

371k69 gold badges769 silver badges659 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

RevanProdigalKnight Over a year ago

In the new RegExp() constructor the flags argument is also a string, so it should be new RegExp('regex', 'g')

falsetru Over a year ago

@RevanProdigalKnight, You're right. Thank you for pointing that. I updated the code accordingly.

Collectives™ on Stack Overflow

regexp javascript in angularjs filter

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related