Find multiple string matches using Java regex

Question

I am trying to use regex to find a match for a string between Si and (P) or Si and (I).

Below is what I wrote. Why isn't it working and how do I fix it?

String Channel = "Si0/4(I) Si0/6( Si0/8K  Si0/5(P)";

if (Channel.length() > 0) {
    String pattern1 = "Si";
    String pattern2 = "(P)";
    String pattern3 = "(I)";

    String P1 = Pattern.quote(pattern1) + "(.*?)[" + Pattern.quote(pattern2) + "|" + Pattern.quote(pattern3) + "]";

    Pattern p = Pattern.compile(P1);
    Matcher m = p.matcher(Channel);

    while(m.find()){
        if (m.group(1)!= null)
        {
            System.out.println(m.group(1));
        }
        else if (m.group(2)!= null)
        {   
            System.out.println(m.group(2));
        }
    }

}

Expected output

0/4
0/5

Actual output

0/4
0/6
0/8K  Si0/5

Avinash Raj · Accepted Answer · 2014-09-04 16:44:23Z

2

Use a lookbehind and lookahead in your regex. And also you need to add space inside the character class, so that it won't this 0/8K string .

(?<=Si)[^\\( ]*(?=\\((?:P|I)\\))

DEMO

String str="Si0/4(I) Si0/6( Si0/8K Si0/5(P)";
String regex="(?<=Si)[^\\( ]*(?=\\([PI]\\))";
Pattern pattern = Pattern.compile(regex);
Matcher matcher =pattern.matcher(str);
while(matcher.find()){
    System.out.println(matcher.group(0));
}

Output:

0/4
0/5

edited Sep 4, 2014 at 16:44

answered Sep 4, 2014 at 16:20

Avinash Raj

175k32 gold badges247 silver badges289 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Tomalak Over a year ago

(?:P|I) = [IP] ;-)

vks · Accepted Answer · 2014-09-04 16:32:48Z

0

You need to group your regex.It is currently

Si(.*?)[(P)|(I)]

Whereas it should be

Si(.*?)\(I\)|Si(.*?)\(P\)

See demo.

http://regex101.com/r/oO8zI4/8

edited Sep 4, 2014 at 16:32

answered Sep 4, 2014 at 16:25

vks

68.1k11 gold badges96 silver badges132 bronze badges

3 Comments

Tomalak Over a year ago

You ought to escape the parentheses: Si(.*?)\([IP]\)

vks Over a year ago

@Tomalak it was der in the regex link.forgot here.thanx

Tomalak Over a year ago

Still not correct, because you have two groups in your expression but actually you only want one.

JSlain · Accepted Answer · 2014-09-04 16:34:09Z

-1

[] means "any of these character", so it evaluates every letter in the block as if they were separated with OR.

If the result you're searching is always: number/number You can use:

Si(\d+\/\d+)(?:\(P\)|\(I\))

answered Sep 4, 2014 at 16:34

JSlain

5764 silver badges21 bronze badges

Collectives™ on Stack Overflow

Find multiple string matches using Java regex

3 Answers 3

1 Comment

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related