Mysql select query/ PHP function is generating an infinite loop

Question

I have a function that is meant to select data from a database to be displayed in a table. The function is generating an endless loop. How may I fix that?

My code is below:

function view()
{
    $db = new mysqli("localhost", "root", "", "blog");
    $sql = 'SELECT * FROM news';
    $result = $db->query($sql) or die($mysqli->error);
    return $result->fetch_assoc();
}
?>
<table>
  <tr>
    <th scope="col">Title</th>
    <th scope="col">Slug</th>
    <th scope="col">Text</th>
  </tr>
  <?php while($row = view()) { ?>
  <tr>
    <td><?php echo $row['title']; ?></td>
    <td><?php echo $row['slug']; ?></td>
    <td><?php echo $row['text']; ?></td>
  </tr>
  <?php } ?>
 </table>

Thanks.

Rodrigo Techera · Accepted Answer · 2014-09-12 21:43:23Z

2

Try this:

function view()
{
    $db = new mysqli("localhost", "root", "", "blog");
    $sql = 'SELECT * FROM news';
    $result = $db->query($sql) or die($mysqli->error);

    $results=array();
    while($row=$result->fetch_assoc())
        $results[] = $row;

    return $results;
}
?>
<table>
  <tr>
    <th scope="col">Title</th>
    <th scope="col">Slug</th>
    <th scope="col">Text</th>
  </tr>
  <?php $results = view();
        foreach($results as $result_index=>$result_values) { ?>
  <tr>
    <td><?php echo $result_values['title']; ?></td>
    <td><?php echo $result_values['slug']; ?></td>
    <td><?php echo $result_values['text']; ?></td>
  </tr>
  <?php } ?>
 </table>

answered Sep 12, 2014 at 21:43

Rodrigo Techera

2511 silver badge9 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Dave · Accepted Answer · 2014-09-12 21:51:50Z

2

you function is re-executing the query every single time you call it.

make your function return the $result variable, and then have your while loop look like this:

<?php $result = view(); while($row = $result->fetch_assoc()) { ?>
  <tr>
    <td><?php echo $row['title']; ?></td>
    <td><?php echo $row['slug']; ?></td>
    <td><?php echo $row['text']; ?></td>
  </tr>
<?php } ?>

EDIT: your view() function should look like this:

function view()
{
    $db = new mysqli("localhost", "root", "", "blog");
    $sql = 'SELECT * FROM news';
    return $db->query($sql) or die($mysqli->error);
}

edited Sep 12, 2014 at 21:51

answered Sep 12, 2014 at 21:40

Dave

8886 silver badges12 bronze badges

1 Comment

Terungwa Over a year ago

function view() { $db = new mysqli("localhost", "root", "", "blog"); $sql = 'SELECT * FROM news'; return $result = $db->query($sql) or die($mysqli->error); } but this is the error i got Fatal error: Call to a member function fetch_assoc() on a non-object in C:\wamp\www\Custom-Menu\array-from-function.php on line 25

Collectives™ on Stack Overflow

Mysql select query/ PHP function is generating an infinite loop

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related