Converting numbers from regex to integer in Ruby

Question

i want to convert numbers from regex to integer. I don’t know how to explain it clearly (my English is bad). So, I’ll go with an example:

regex      = /data:\s*(\d+(?:\s*,\s*\d+)*)/i
string     = "Data: 1, 2, 3, 4"
data       = string.match(regex)
split_data = data[1].split(", ")
int_data1  = split_data.each {|i|i = i.to_i}
int_data2  = [1, 2, 3, 4]
p int_data1, int_data2

# int_data1 => ["1", "2", "3", "4"]
# int_data2 => [1, 2, 3, 4]

I expected int_data1 to return [1, 2, 3, 4], but it can't be converted to integer. So, it keeps return me ["1", "2", "3", "4"].

Is something I do wrong?

each() returns the original array. So to use each(), you would have to do something like this: int_data1 = []; split_data.each {|str| int_data << str.to_i} — 7stud
– 7stud, Commented Sep 20, 2014 at 16:37
@7stud another way with each. [1,2,3,4].to_enum(:map).each { |x| x + 1 } -> [2, 3, 4, 5] — Roman Kiselenko
– Roman Kiselenko, Commented Sep 20, 2014 at 16:50

Community · Accepted Answer · 2017-05-23 12:05:49Z

1

This:

int_data1 = split_data.each { |i| i = i.to_i }

Should be:

int_data1 = split_data.map { |i| i.to_i }

Or more short syntax:

int_data1 = split_data.map(&:to_i)

Read about difference between .each() and .map()

edited May 23, 2017 at 12:05

CommunityBot

11 silver badge

answered Sep 20, 2014 at 16:35

Roman Kiselenko

44.5k9 gold badges100 silver badges111 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Converting numbers from regex to integer in Ruby

1 Answer 1

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related