Javascript Code for Coderbyte issue

Question

Hi guys working on a problem in javascript from coder bytes. The problem is:

Using the JavaScript language, have the function ABCheck(str) take the str parameter being passed and return the string true if the characters a and b are separated by exactly 3 places anywhere in the string at least once (ie. "lane borrowed" would result in true because there is exactly three characters between a and b). Otherwise return the string false.

Use the Parameter Testing feature in the box below to test your code with different arguments.

function abcheck(str){
        for(var i = 0; i < str.length; i++) {
            if(str.split(" ")[i] === "a" && str.split(" ")[i+4] === "b")
                {
                    return true;    
                }
            else{
                    return false;
            }
    }
}

After doing a check

abcheck("Laura sobs")

I am getting false. Can anyone spot what I am doing wrong?

steelthunder · Accepted Answer · 2014-09-21 01:21:35Z

1

Try this. Used alert to better demonstrate. You were splitting the strings at the space instead of every character like I think you were trying to do.

<script>
str="Laura sobs";

function abcheck(str){
        for(var i = 0; i < str.length; i++) {
            if(str.split("")[i] === "a" && str.split("")[i+4] === "b")
                {
                    alert ("true")    
                }
            else{
                    // do nothing
            }
    }
}

abcheck("Laura sobs")

</script>

answered Sep 21, 2014 at 1:21

steelthunder

4382 gold badges12 silver badges27 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Ben Broadley · Accepted Answer · 2014-09-21 01:29:12Z

0

I think the issue you are facing here is the use of the Split function as this will separate your string into an array of words (using a space character as an indication of a new word).

Also, your for loop could encounter issues when it reaches the end of the string, lets say the string was 10 characters long, once the loop reaches its 7th iteration, it will no longer be able to add 4 to the index and check the character in that position, so it would be best to only iterate as far as the 4th from last character, since we already know that there wont be any further possible checks to carry out

Removing both instances of split(" ") from your code, and changing your loop condition slightly should fix the issue you are experiencing, therefore I believe the function should look something like this:

function abcheck(str){
        for(var i = 0; i < str.length - 4; i++) {
            if(str[i] === "a" && str[i+4] === "b")
                {
                    return true;    
                }
            else{
                    return false;
            }
    }
}

Finally, depending on how thorough you need your function to be, you may also need to test for capitalised versions of these letters (i.e. using str.toLowerCase() inside your condition).

answered Sep 21, 2014 at 1:29

Ben Broadley

6326 silver badges14 bronze badges

1 Comment

theamateurdataanalyst Over a year ago

This code is wrong actually. I can't figure out why though.

Md Altaf Raja · Accepted Answer · 2022-02-11 10:18:38Z

0

function ABCheck(str) {
  if (str.length < 5) {
    return false;
 }
  console.log(str.length);
  for (let i = 0; i < str.length - 4; i++) {
    // look for a
    if (str[i] === 'a') {
      if (str[i + 4] === 'b') {
        return true;
      }
    }

    if (str[i] === 'b') {
      if (str[i + 4] === 'a') {
        return true;
      }
    }
  }

  return false;
}

answered Feb 11, 2022 at 10:18

Md Altaf Raja

11 bronze badge

1 Comment

Md Altaf Raja Over a year ago

Input: "after badly" Output: false Input: "Laura sobs" Output: true

Collectives™ on Stack Overflow

Javascript Code for Coderbyte issue

3 Answers 3

Comments

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related