add javascript variable in image url

Question

My Random Number Generate code is

var randomnumber=Math.floor(Math.random()*99999)

Now I want to put this variable output in a image scr url..

Here is my url

<img src="http://www.myexample.com/get/image.php?vcid=14851&t=481" alt="" id="imge"/>

So what will my code?

<img src="http://www.myexample.com/get/image.php?vcid='+ randomnumber +'&t=481" alt="" id="imge"/>

??

Please help me

In your second .src line, replace the single-quotes with double-quotes. — vernonner3voltazim
– vernonner3voltazim, Commented Sep 21, 2014 at 19:11
Perhaps you should show us what the PHP code does with the received URL data? (My previous comment was related to, "no need to pass the random number as a string", which is what happens when you use those single-quotes.) There ARE ways in which PHP can fail to transmit an image. — vernonner3voltazim
– vernonner3voltazim, Commented Sep 21, 2014 at 22:35

malifa · Accepted Answer · 2014-09-21 19:30:09Z

1

In pure Javascript you could do it like

var randomNumber = 1;
var image = document.getElementById("imageId");
var imageSrc = image.getAttribute("src");
image.setAttribute("src", imageSrc + randomNumber);

To put your number at the correct place you could use some string split functions, but since the order of query strings don't matter you should just put your vcid query at the end.

edited Sep 21, 2014 at 19:30

answered Sep 21, 2014 at 19:07

malifa

8,1552 gold badges44 silver badges57 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

NoDiv_NoClass Over a year ago

I change your last line and Its work for me.. last line will be: document.getElementById("imge").setAttribute("src", imageSrc + randomNumber); So... Code will be <script> var randomnumber=Math.floor(Math.random()*99999) var imageSrc = document.getElementById("imge").getAttribute("src"); document.getElementById("imge").setAttribute("src", imageSrc + randomnumber); </script>

malifa Over a year ago

you're right, i forgot to declare the image variable. i edited my answer.

Johan Karlsson · Accepted Answer · 2014-09-21 19:06:35Z

0

Try adding this in your <script>:

document.getElementById("imge").src = "http://www.myexample.com/get/image.php?vcid=" + randomnumber + "&t=481";

answered Sep 21, 2014 at 19:06

Johan Karlsson

6,4761 gold badge22 silver badges28 bronze badges

Comments

David Thomas · Accepted Answer · 2014-09-21 19:32:06Z

0

I'd personally suggest:

var img = document.getElementById('imge');

img.src = img.src.replace(/vcid=(\d+)/, function(){
  return randomnumber=Math.floor(Math.random()*99999);
});
// purely to see the src has been changed, this is *not* relevant or required
img.title = img.src;

<img src="http://www.myexample.com/get/image.php?vcid=14851&t=481" alt="" id="imge"/>

References:

answered Sep 21, 2014 at 19:32

David Thomas

254k53 gold badges382 silver badges421 bronze badges

Collectives™ on Stack Overflow

add javascript variable in image url

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related