delete query not working in php/mysql?

Question

I tried everything I could find online to get it to work, I tried casting $employeeid to int after retrieving it from the link (even though they say mysql does it for you), i tried using nested single quotes, escape quotes... the print line happens to work, and employeeid shows up as a number in the hyperlink when delete is clicked, but it never deletes. what could I be doing wrong?

also, I could've sworn the onclick="return confirm("")" in the hyperlink was supposed to cause a pop up to appear, but it didnt, am I forgetting something here as well or is it a syntax issue?

this is my php link that calls it:

<td><a href='employ.php?delete=yes&employeeid=$employeeid onclick=\"return confirm(\"Are you sure\")\"'>Delete</a></td>

and this is the code section that is supposed to handle it:

if(isset($_GET['delete']))
{
    $temp = $_GET['$employeeid'];
    print "teseting delete<br><br>";
    $query = "DELETE FROM employees WHERE employeeid = ".$temp;
    mysqli_query($link, $query); //link query to database
    print "Employee Updated"; // print confirmation

}

have you checked with print_r($_GET); at the top to confirm that the data passes?? — Ronser
– Ronser, Commented Oct 15, 2014 at 7:07
Replace $temp = $_GET['$employeeid']; with $employeeid = $_GET['employeeid']; then do WHERE employeeid = ".$employeeid; — Funk Forty Niner
– Funk Forty Niner, Commented Oct 15, 2014 at 7:08
wowwwwwww this is why i hate coding late at night @_@ i spend all night thinking i dont understand the concepts and its dumbass syntax >.< — J L
– J L, Commented Oct 15, 2014 at 7:12
well everyone sorta answered the problem at the same time lol. — J L
– J L, Commented Oct 15, 2014 at 7:13

jpcanamaque · Accepted Answer · 2014-10-15 07:08:50Z

2

Try this:

PHP

if(isset($_GET['delete']))
{
    $temp = $_GET['employeeid']; <<=== remove the $ sign
    print "teseting delete<br><br>";
    $query = "DELETE FROM employees WHERE employeeid = ".$temp;
    mysqli_query($link, $query); //link query to database
    print "Employee Updated"; // print confirmation
}

And on your link:

<td>
     <a href="employ.php?delete=yes&employeeid=$employeeid" onclick= 'return confirm("Are you sure")'>Delete</a>
</td>

Take note on the href attribute, it is enclosed in double quotes since you are putting PHP variables in your link

answered Oct 15, 2014 at 7:08

jpcanamaque

1,0791 gold badge8 silver badges15 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

J L Over a year ago

awesome it really is too late for me to be doing all this coding >.< or maybe i just need more php practice

jpcanamaque Over a year ago

Everybody has gone to that 'scratch-your-head' stage when committing mistakes. Just continue practicing, as we all programmers do. :)

Barmar · Accepted Answer · 2014-10-15 07:07:55Z

2

href andonclick are separate attributes, you have them combined into one.

<td><a href='employ.php?delete=yes&employeeid=$employeeid' onclick='return confirm(\"Are you sure\")'>Delete</a></td>

answered Oct 15, 2014 at 7:07

Barmar

789k57 gold badges554 silver badges669 bronze badges

1 Comment

J L Over a year ago

thanks i hate it when I'm scratching my head forever over that kinda thing.

jogesh_pi · Accepted Answer · 2014-10-15 07:08:31Z

1

Make sure the Variable in GET Method that you are using $employeeid, May be it is employeeid

$temp = $_GET['employeeid'];

answered Oct 15, 2014 at 7:08

jogesh_pi

9,7725 gold badges40 silver badges65 bronze badges

Comments

Sidhhraj Maharaul · Accepted Answer · 2014-10-15 07:11:09Z

0

check your table name , field name ,user permission in mysql and relation with other table . if u use foreign key of employeeId in another table then also you not able to delete

answered Oct 15, 2014 at 7:11

Sidhhraj Maharaul

563 bronze badges

Comments

Choco · Accepted Answer · 2014-10-15 07:14:03Z

0

Try this I hope this may helpful

if(isset($_GET['delete']))
{
    $temp = $_GET['employeeid']; 
    print "teseting delete<br><br>";
    $query = "DELETE FROM employees WHERE employeeid = ".$temp;
    mysqli_query($link, $query); //link query to database
    print "Employee Updated"; // print confirmation
}
<td><a href="test.php?delete=yes&employeeid=<?=$employeeid;?>" onclick= 'return confirm("Are you sure")'>Delete</a></td>

answered Oct 15, 2014 at 7:14

Choco

1,0641 gold badge7 silver badges20 bronze badges

Comments

Hara Prasad · Accepted Answer · 2014-10-15 07:32:21Z

0

$query = mysqli_query($link,"DELETE FROM employees WHERE employeeid ='$temp'");

edited Oct 15, 2014 at 7:32

answered Oct 15, 2014 at 7:11

Hara Prasad

7128 silver badges16 bronze badges

1 Comment

Funk Forty Niner Over a year ago

Just a quick FYI: In mysqli_, the DB connection comes first, not last. See Johnroe's answer, that is the solution.

Collectives™ on Stack Overflow

delete query not working in php/mysql?

6 Answers 6

2 Comments

1 Comment

Comments

Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

2 Comments

1 Comment

Comments

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related