Java program output strange result

Question

I am having an output problem with my java code. I am trying to implement this multiply matrix method and it compiles just fine. The only problem is my output. I seem to be getting the following:

  ---- Test Multiply Matrix ----
[[D@7f31245a 
Should return C={{ 3, 2},{ 1, 1}}

Can someone please help me understand where I am going wrong here. Thanks! Here is my source code:

public class Recommendation 
{
public static double[][] multiplyMatrix(double[][] A, double[][] B)
{
    int aRows = A.length;
    int bRows = B.length;
    int aColumns = A[0].length;
    int bColumns = B[0].length;

    if((aColumns != bRows))
    {
        return null;
     }
    else
    {
        double[][] C = new double[aRows][bColumns];
        for (int i = 0; i < 2; i++) 
        {
            for (int j = 0; j < 2; j++) 
            {
                C[i][j] = 0;
            }
        }

        for (int i = 0; i < aRows; i++) 
        {
            for (int j = 0; j < bColumns; j++) 
            { 
                for (int k = 0; k < aColumns; k++) 
                {
                C[i][j] += A[i][k] * B[k][j];
                }
            }
        }
        return C;
    }
}
static double [][] A =  {{ 1, 0, 2},
                        {  0, 1, 1}};
static double [][] B =  {{1, 2},
                        { 0, 1},
                        { 1, 0}};

    public static void main(String[] argss)
    {
    // TEST multiplyMatrix      
    System.out.println(" ---- Test Multiply Matrix ---- ");
    System.out.println(multiplyMatrix(A,B)); // should return C={{ 3, 2},{ 1, 1}}
    System.out.println("Should return C={{ 3, 2},{ 1, 1}}");
    System.out.println(" ");
    }      
 }

rethab · Accepted Answer · 2014-10-22 12:07:46Z

3

You might want to use Arrays.toString from java.util.Arrays to print arrays.

Or, if you want your output to be a little more custom, you can iterator over the array.

answered Oct 22, 2014 at 12:07

rethab

8,69339 silver badges55 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Eran · Accepted Answer · 2014-10-22 12:14:38Z

1

Note that Arrays.toString alone won't help you, since your array is two dimensional.

It would still print something of the form : [[I@355d56d5, [I@2efd552, [I@4f9dfbff]

Instead, you can do something like this :

double[][] C = multiplyMatrix(A,B);
for (double[] subArray : C) {
   System.out.print (Arrays.toString (subArray));
   System.out.print (" , ");
}
System.out.println();

Or, you can use Arrays.deepToString(C) which will take care of the hierarchy for you.

answered Oct 22, 2014 at 12:14

Eran

395k57 gold badges726 silver badges793 bronze badges

2 Comments

Will Over a year ago

This was very helpful. However my end result that I am trying to end up with is: {{ 3, 2},{ 1, 1}} and with the arrays I seem to be getting [3.0, 2.0] , [1.0, 1.0]. Is there any way of changing this?

Eran Over a year ago

@Will This is the default format of Arrays.toString. If you want a different format, you can iterate over the arrays and print them however you like.

Akash Thakare · Accepted Answer · 2014-10-22 12:58:38Z

1

#deepToString Returns a string representation of the "deep contents" of the specified array. If the array contains other arrays as elements, the string representation contains their contents and so on. This method is designed for converting multidimensional arrays to strings.

You should use java.util.Arrays.deepToString(array) for multi-dimensional array.Currently you are printing Object reference's String representation.

You can use #replace method to replace[] with {}

//...
public static void main(String[] argss){
    // TEST multiplyMatrix      
    System.out.println(" ---- Test Multiply Matrix ---- ");
    double array[][] = multiplyMatrix(A,B);
    String finalString = Arrays.deepToString(array)
                               .replace("[", "{")
                               .replace("]", "}");
    System.out.println(finalString);
    }//...

edited Oct 22, 2014 at 12:58

answered Oct 22, 2014 at 12:15

Akash Thakare

23k11 gold badges64 silver badges89 bronze badges

5 Comments

Will Over a year ago

Thanks for the follow up although I am struggling to implement it... Is this correct? I have added the code to your answer as too hard to read otherwise

Will Over a year ago

Also my method public static double[][] multiplyMatrix(double[][] A, double[][] B) is meant to have a return. It used to be C, now what am I meant to return as this prints the string already?

Will Over a year ago

Ok, I think I am missing something here. I have added the code to yours to view it better and have put the output I am getting.

Will Over a year ago

I don't follow what you said, if I take: String finalString = Arrays.deepToString(C) .replace("[", "{") .replace("]", "}"); and put it outside of the method how would that work? There would be no variable and the test class would only call the method not what follows...? Im sorry Im still a bit lost here

Will Over a year ago

Thanks for keeping on trying. The problem is the String has to be changed within the method. It will be passed through a test file and the test class will only call the method - the answer has to be displayed exactly how they want it afterwards. Any ideas?

TheLostMind · Accepted Answer · 2014-10-22 12:08:31Z

0

public static double[][] multiplyMatrix(double[][] A, double[][] B). Here you are returning a double array. which is not a primitive type. So, the default toString() method of array will be used (Which prints classname@hashCode, hence the output). You have to use Arrays.toString() to print the values properly.

answered Oct 22, 2014 at 12:08

TheLostMind

36.3k12 gold badges72 silver badges109 bronze badges

Comments

Anders R. Bystrup · Accepted Answer · 2014-10-22 12:10:46Z

0

[[D@7f31245a means a 2D array of Double's followed by the hashcode of the actual object.

Your multiplyMatrix() method returns exactly this, but the toString() method invoked is that on Object which prints exactly this. You'll need to to use methods on Arrays class to prettyprint arrays.

Cheers,

answered Oct 22, 2014 at 12:10

Anders R. Bystrup

16.1k11 gold badges65 silver badges59 bronze badges

Comments

Maroun · Accepted Answer · 2014-10-22 12:15:27Z

0

You can use Arrays#deepToString():

System.out.println(Arrays.deepToString(multiplyMatrix(A,B)));

multiplyMatrix returns an array, which is an object, and in Java since each object has toString() method, the default is displaying the class name representation, then adding @ sign and then the hashcode.

In order to better understand what's happening here, see the implementation of Arrays.deepToString.

Note that if you want more control on the output, e.g. filtering some arrays or change the way display them, you can have nested loops.

edited Oct 22, 2014 at 12:15

answered Oct 22, 2014 at 12:08

Maroun

96.3k30 gold badges195 silver badges249 bronze badges

1 Comment

Will Over a year ago

I tried using this code but I now get the following: ---- Test Multiply Matrix ---- [[D@7f31245a, [D@6d6f6e28] Should return C={{ 3, 2},{ 1, 1}}

Collectives™ on Stack Overflow

Java program output strange result

6 Answers 6

Comments

2 Comments

5 Comments

Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

Comments

2 Comments

5 Comments

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related