Insert into database using a while loop

Question

I need to insert data from a table named wishlist into another table (wishlisturi_salvate) and altough the insert looks ok, something doesn't work right and no inseration is being made.Thanks for the help, I really appreciate it.

<?php
session_start();
include ('conex.php');
$sel2="select id_wishlist  from wishlisturi_salvate";
$que2=mysql_query($sel2);
while($rez2=mysql_fetch_array($que2))
{
$a=$rez2['id_wishlist'];
}
$id_wishlist=$a;
echo $id_wishlist;
$sel="SELECT * from wishlist";
$que=mysql_query($sel);
while ($rez=mysql_fetch_array($que))
{
$insert="INSERT INTO 'wishlisturi_salvate'('id_user', 'id_wishlist', 'id_produs',        'nume_produs', 'pret_produs', 'cantitate_produs', 'suma') 
   VALUES('".$_SESSION['id']."','".$id_wishlist."','".$rez['id_produs']."','".$rez['nume_produs']."','".$rez['pret_produs']."','".$rez['cantitate_produs']."','".$rez['suma']."')";
if(!mysql_query($insert)) echo "fml";
echo "<br>".$insert;
}

if(mysql_query($insert))
{
header("location:user.php");
}
else echo "Nu s-a facut inserarea"; 
?>

echo mysql_error() is your friend.

Gerald Schneider
– Gerald Schneider

2014-11-02 10:27:10 +00:00
Commented Nov 2, 2014 at 10:27 — Gerald Schneider
– Gerald Schneider, Commented Nov 2, 2014 at 10:27

Community · Accepted Answer · 2017-05-23 10:33:19Z

1

No insertion is being made most likely because of the errors inside the query:

Right of the bat, there is already an error:

INSERT INTO 'wishlisturi_salvate'('id_user', 'id_wishlist', 'id_produs',        'nume_produs', 'pret_produs', 'cantitate_produs', 'suma')

The proper quoting of table/column names must be backtickts, not single quotes

INSERT INTO `wishlisturi_salvate` (`id_user`, `id_wishlist`, `id_produs`, `nume_produs`, `pret_produs`, `cantitate_produs`, `suma`)

Or just omit them, its okay in this case.

Obligatory Note:

Please, don't use mysql_* functions in new code. They are no longer maintained and are officially deprecated. See the red box? Learn about prepared statements instead, and use PDO or MySQLi - this article will help you decide which. If you choose PDO, here is a good tutorial.

Sidenote:

If you haven't already, always turn on error reporting:

error_reporting(E_ALL);
ini_set('display_errors', '1');

edited May 23, 2017 at 10:33

CommunityBot

11 silver badge

answered Nov 2, 2014 at 10:18

Kevin

41.9k12 gold badges57 silver badges72 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

mihaicata1205 Over a year ago

yeah, i've made a mistake, but i tried without the single quotes and with the backtickts but it still isn't working, so that's not the major problem.Can you figure it out? I really need to get this thing going, because this is a project and i'm running out of time...

Kevin Over a year ago

@mihaicata1205 just do a step by step debugging, start off with the first query, check if the id is properly echoed, next build the sql statement for the next query, echo that again, and you can use an mysql_query(..) or die(mysql_error());

mihaicata1205 Over a year ago

yeah, i've tried but i can't figure out the problem.Is there anything wrong with the insert?(except for the single quotes)

Kevin Over a year ago

@mihaicata1205 try to echo $insert and use it on phpmyadmin to find out

M0N0NE · Accepted Answer · 2014-11-02 10:25:23Z

0

First of all I'll rcomend you to use PDO or mysqli instead of mysql to avoid SQL injection.

Anyway, if you want to insert elements from one table to another one I recommend you to use an insert statment with a subselect. That way it'll be faster and you will waste less memory.

answered Nov 2, 2014 at 10:25

M0N0NE

631 gold badge2 silver badges8 bronze badges

Comments

Cups · Accepted Answer · 2014-11-02 10:27:00Z

0

Not an answer, more of an observation ; It will be far more efficient to loop through your results to build up a single SQL insert multiple statement that you send to the db once.

$insert = "INSERT INTO 'wishlisturi_salvate'('id_user', 'id_wishlist', 'id_produs',        'nume_produs', 'pret_produs', 'cantitate_produs', 'suma') VALUES ";

foreach( of your results ){
$insert .= "(x,y,z,a,b,c,d),";
}

// now trim off last comma, then send to db.
// or create an array then join it to the $insert

Same info can be read here : http://www.electrictoolbox.com/mysql-insert-multiple-records/

answered Nov 2, 2014 at 10:27

Cups

6,9063 gold badges29 silver badges30 bronze badges

2 Comments

Cups Over a year ago

Ah yes, subselect as user1514329 says. Do the work in your db.

mihaicata1205 Over a year ago

that's right, thanks for the advice but first i need to get this thing going, than i can optimize it.

Collectives™ on Stack Overflow

Insert into database using a while loop

3 Answers 3

4 Comments

Comments

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

4 Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related