Finding ArrayList elements in ArrayList

Question

I have two ArrayList userActions and actionsToCheck of type enum Action.

I want to check if all the elements in actionsToCheck is present in userActions.

Is the following good enough or is there a better way?

private boolean actionsAllowed(ArrayList<Action> userActions, ArrayList<Action> actionsToCheck){
    return actionsToCheck.stream().allMatch(action-> actionAllowed(userActions,action));
}

private boolean actionAllowed(ArrayList<Actions> userActions, Action action){
    return userActions.stream().anyMatch(userAction -> userAction == action);
}

ArrayList<Actions> userAction=new ArrayList<>();
userAction.add(ADD_USER);
userAction.add(DELETE_USER);
userAction.add(MODIFY_USER);

ArrayList<Actions> actionsToCheck=new ArrayList<>();
actionsToCheck.add(ADD_USER);
actionsToCheck.add(DELETE_USER);

actionsAllowed(userAction,actionsToCheck) //should return true

Whether or not it is good, it is unreadable. I suggest making a predicate function out of this, naming it well, and reducing the "chained calls off the edge of the stream". — msw
– msw, Commented Jan 19, 2015 at 11:50

Maarten Winkels · Accepted Answer · 2015-01-19 18:47:28Z

2

You could simply use Collection.containsAll(collection) to do your check.

In addition I would recommend using EnumSet instead of ArrayList.

answered Jan 19, 2015 at 18:47

Maarten Winkels

2,41716 silver badges16 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Finding ArrayList elements in ArrayList

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related