Android: How to reference TextView via String variable?

Question

How can I reference TextView by using its id in a String variable, like:

xml file:

<TextView
    android:id="@+id/hello1"
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    android:text=""
    />
<TextView
    android:id="@+id/hello2"
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    android:text=""
    />

code:

 public void changetext(String z){
    String x ="R.id.hello"+z;
    TextView y = (TextView) findViewById(x);
    y.setText("I've changed");
}

for more info check the source androidxref.com/5.0.0_r2/xref/frameworks/base/core/java/android/… — Raghunandan
– Raghunandan, Commented Jan 23, 2015 at 2:57

Vladimir Petrakovich · Accepted Answer · 2015-01-23 03:54:31Z

2

Change your code to

public void changeText(String z){
    String x = "hello" + z;
    int id = getResources().getIdentifier(x, "id", getPackageName());
    TextView y = (TextView) findViewById(id);
    y.setText("I've changed");
}

answered Jan 23, 2015 at 3:54

Vladimir Petrakovich

4,3061 gold badge32 silver badges47 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Hiren Patel · Accepted Answer · 2015-01-23 03:59:17Z

0

Define two variables of textviews

TextView txt1 = findViewById(R.id.txt_one);
TextView txt2 = findViewById(R.id.txt_two);         
setTextOnTextView("Good morning", txt1);

Method will settext on textview which you have passed to method

private void setTextOnTextView(String text, TextView txtView){
        String x ="Hello My Text"+" "+text;
        txtView.setText("I've changed");
}

answered Jan 23, 2015 at 3:59

Hiren Patel

52.9k21 gold badges177 silver badges153 bronze badges

Comments

Anggrayudi H · Accepted Answer · 2015-01-23 04:00:18Z

0

The problem comes from your public void changetext(String z) method. Change to:

public void changeText(Activity a, int textViewId, String text) {
    TextView tv = (TextView) a.findViewById(textViewId);
    String x = "Hello:" + text; // or you can write "String x = text;" only if needed.
    tv.setText(x);
}

Here's how to use above method:

changeText(MyCurrentActivity.this, R.id.hello1, "Hi, this is my text.");

And the output will looks like this:

Hello: Hi, this is my text.

edited Jan 23, 2015 at 4:00

answered Jan 23, 2015 at 3:27

Anggrayudi H

15.2k13 gold badges59 silver badges89 bronze badges

Collectives™ on Stack Overflow

Android: How to reference TextView via String variable?

3 Answers 3

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related