Update MySQL entries via PHP/Html & sql

Question

Im trying to create a form where based on someones first and surname, their email can be changed.

So the html looks like this:

<form action="sUpdateResponse.php" method="post">
<input type="text" placeholder="Enter Email..." name="sUpdateEmail">
Where the name is 
<input type="text" placeholder="Enter Forename..." name="sUpdateFN">
<input type="text" placeholder="Enter Surname..." name="sUpdateSN">
    <input type="submit" value="Update Records" name="sRetrieveUpdate"></form>

This takes a new email to update the data entry where the forename and surname exist.

The php on sUpdateResponse looks like this,

if($_POST['sRetrieveUpdate']) 
    $queryRetrieve = mysql_query( "UPDATE staffData SET sEmail='".$_POST['sUpdateEmail']."' WHERE sFN='".$_POST['sUpdateFN']."' 
    AND sFN='".$_POST['sUpdateSN']."'" );

This doesn't return an error but doesn't seem to alter the email either...

Where am i going wrong?

Please, don't use mysql_* functions in new code. They are no longer maintained and are officially deprecated. See the red box? Learn about prepared statements instead, and use PDO or MySQLi - this article will help you decide which. If you choose PDO, here is a good tutorial. You are also wide open to SQL injections — John Conde
– John Conde, Commented Feb 16, 2015 at 14:13
Also, did you check if values for sUpdateEmail etc are set? 'isset' for instance. Make an 'else' statement for sRetrieveUpdate also, does it exists 100% and is not null or empty string? — trainoasis
– trainoasis, Commented Feb 16, 2015 at 14:16
your code is nice but not longer supported now. Unfortunately. Otherwise, your page will be full of fake scripts. — Herman Nz
– Herman Nz, Commented Feb 16, 2015 at 14:16

Hardik Bharadava · Accepted Answer · 2015-02-16 14:27:25Z

1

<?php
if(isset($_POST['sRetrieveUpdate'])){
      if(isset($_POST['sUpdateEmail']) && isset($_POST['sUpdateFN']) && isset($_POST['sUpdateSN'])){
            $query = "UPDATE staffData SET sEmail = '.$_POST['sUpdateEmail'].' WHERE sFirstName = '.$_POST['sUpdateFN'].' AND sSurName = '.$_POST['sUpdateSN']";
            $Result = mysqli_query($query);
      }else{
            // Error Message
      }
}else{
      // Error Message
}
?>

answered Feb 16, 2015 at 14:27

Hardik Bharadava

4721 gold badge10 silver badges22 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

ili Over a year ago

Parse error: syntax error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING in || $query line

Hardik Bharadava Over a year ago

I was forgot to put " surrounding to $_POST['sUpdateEmail'] Just put " surrounding it. Like, ".$_POST['sUpdateEmail']." with all three Posting Value.

ili Over a year ago

Warning: mysqli_query() expects at least 2 parameters, 1 given

Hardik Bharadava Over a year ago

@ili, Are you using OO Style or Procedural Style? You may refer here to get Solution of this, both the options are here. you may easily solve it. :)

Tanmoy Roy · Accepted Answer · 2015-02-16 14:26:53Z

0

"UPDATE staffData SET sEmail='".$_POST['sUpdateEmail']."' WHERE sFN='".$_POST['sUpdateFN'].$_POST['sUpdateSN']."'"

answered Feb 16, 2015 at 14:26

Tanmoy Roy

1

Comments

Developer · Accepted Answer · 2015-02-16 16:46:24Z

0

Your Second column is same in where condition sFn repeated. WHERE sFN='".$_POST['sUpdateFN']."' AND sFN='".$_POST['sUpdateSN']."'")

It cheks two values in same column . There is your column name mistake in the query.make it correct then it will work fine :)

It should be Something like this if($_POST['sRetrieveUpdate']) $queryRetrieve = mysql_query( "UPDATE staffData SET Email='".$_POST['sUpdateEmail']."' WHERE sFN='".$_POST['sUpdateFN']."' AND sSN='".$_POST['sUpdateSN']."'" );

edited Feb 16, 2015 at 16:46

answered Feb 16, 2015 at 14:23

Developer

71 silver badge4 bronze badges

Collectives™ on Stack Overflow

Update MySQL entries via PHP/Html & sql

3 Answers 3

4 Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

4 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related