PHP Get variable to equal value of switch

Question

I am trying to get a variable on my page to equal the result of a switch I have.

This is the code:

$payment_method = switch ($cardtype) {
case "visa" : echo "VSA"; break;
case "mastercard" : echo "MSC"; break;
case "maestro" : echo "MAE"; break;
case "amex" : echo "AMX" ; break;
default : echo "Please specify a payment method!"; break;
};

How can I get $payment_method to equal the result of this????

So far I recieve an error:

Parse error: syntax error, unexpected T_SWITCH in /var/www/account/credits/moneybookers/process.php on line 65

@Col. Shrapnel: lol, the same question from the same user %-) — zerkms
– zerkms, Commented May 23, 2010 at 14:13
Not quite the same. He's asking for the variable assignment now, not echo. But that's why all these codes a bad: he's just copy/baste it without understanding. — Your Common Sense
– Your Common Sense, Commented May 23, 2010 at 14:17

zerkms · Accepted Answer · 2010-05-23 14:07:36Z

17

do in this way:

$types = array('visa' => 'VSA', 'mastercard' => 'MSC', 'maestro' => 'MAE', 'amex' => 'AMX');
if (isset($types[$cardtype])) {
    $payment_method = $types[$cardtype];
} else {
    echo 'Please specify a payment method!';
}

answered May 23, 2010 at 14:07

zerkms

256k73 gold badges447 silver badges551 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Eric · Accepted Answer · 2013-08-09 14:29:07Z

12

Use arrays!

$types = array("visa"       => "VSA",
               "mastercard" => "MSC",
               "maestro"    => "MAE",
               "amex"       => "AMX");

$type = @$types[$cardtype] or echo "Please specify a payment method!";

edited Aug 9, 2013 at 14:29

answered May 23, 2010 at 14:09

Eric

98.1k54 gold badges257 silver badges389 bronze badges

Comments

salathe · Accepted Answer · 2010-05-23 14:06:52Z

9

You should assign the value within the switch:

switch ($cardtype) {
    case "visa":
        $payment_method = "VSA";
    break;
    case "mastercard":
        $payment_method = "MSC";
    break;
    case "maestro":
        $payment_method = "MAE";
    break;
    case "amex":
        $payment_method = "AMX";
    break;
    default:
        echo "Please specify a payment method!";
    break;
};

answered May 23, 2010 at 14:06

salathe

52.1k12 gold badges108 silver badges134 bronze badges

Comments

Pekka · Accepted Answer · 2010-05-23 14:05:50Z

4

You can't use the switch construct this way. You would have to assign $payment_method within the case parts.

In your case, seeing as you're echo ing anyway, you can just remove $payment_method = and it should work.

What would be much, much easier, though, is putting all the stuff into an array:

$payment_methods = array(
  "visa" => "VSA",
  "mastercard" => "MSC",
  "maestro" => "MAE",
  "amex" => "AMX"
);

if (!array_key_exists($cardtype, $payment_methods))
 echo "Please specify a payment method!";
else
 echo "Your method: ".$payment_methods[$cardtype];

answered May 23, 2010 at 14:05

Pekka

451k150 gold badges989 silver badges1.1k bronze badges

Comments

Kev · Accepted Answer · 2011-06-11 13:48:36Z

3

For your application, an associative array will be the best solution. To answer your question however, you can build your own switch/case out of ? operators

var card  = 'amex'; //however you retrieve that value

var method = card == 'visa' ? 'VSA' : card == 'mastercard' ? 'MSC' : card == 'maestro' ? 'MAE' : card == 'amex' : 'AMX' : null;  //default value is null

//  store error msgs elsewhere in the code, to ease translation/alteration
var errs = {
 'ENG', {'Please specify a payment method', '...', '...', '...'},
 'ESP', {'Favor, indique la forma de pago', '...', '...', '...'},
 'DEU', {'Bitte geben Sie eine Zahlungsmethode', '...','...','...'}
}

//  alert the appropriate error message, in the current language

var currentLang = 0; //however you set that value
if(!method) alert(errs[currentLang][0]);

edited Jun 11, 2011 at 13:48

Kev

120k53 gold badges308 silver badges396 bronze badges

answered Jun 11, 2011 at 3:31

2strokeMotor

311 bronze badge

1 Comment

wlf Over a year ago

you shouldn't use the ternary operator in such a way. Readibility is paramount and in this case a switch is the best way to go.

Ostap Brehin · Accepted Answer · 2021-05-22 17:23:00Z

3

Use match statement.

https://www.php.net/manual/en/control-structures.match.php

Example:


$message = match ($statusCode) {
    200, 300 => null,
    400 => 'not found',
    500 => 'server error',
    default => 'unknown status code',
};

Also: https://stitcher.io/blog/php-8-match-or-switch

answered May 22, 2021 at 17:23

Ostap Brehin

4,2203 gold badges30 silver badges35 bronze badges

Comments

score 2 · Accepted Answer · 2010-05-23 14:20:36Z

2

You should do:

$payment_method = '';

switch ($cardtype) {
  case "visa" : $payment_method = "VSA"; break;
  case "mastercard" : $payment_method = "MSC"; break;
  case "maestro" : $payment_method = "MAE"; break;
  case "amex" : $payment_method = "AMX" ; break;
}

if (strlen($payment_method))
{
  echo $payment_method;
}
else
{
  echo "Please specify a payment method!";
}

edited May 23, 2010 at 14:20

answered May 23, 2010 at 14:06

Web Logic

5 Comments

zerkms Over a year ago

default : $payment_method = "Please specify a payment method!"; // with this implementation it will be impossible to get is payment method valid or not.

Web Logic Over a year ago

@zerkms: right, fixed main, please consider your down vote. Thanks

zerkms Over a year ago

@Wed Logic: fixed ;-) btw, he will get notice with this code, when $cardtype is invalid

Web Logic Over a year ago

@zerkms: What he would notice, could not get you?

zerkms Over a year ago

now - nothing. i have commented the revision #2 without if(strlen()), which you have added later ;-)

score 1 · Accepted Answer · 2018-02-03 18:31:14Z

1

If you don't want to change your code (like if you have very long switch), you can use Output Buffering.

<?php
ob_start();
switch ($cardtype) {
case "visa" : echo "VSA"; break;
case "mastercard" : echo "MSC"; break;
case "maestro" : echo "MAE"; break;
case "amex" : echo "AMX" ; break;
default : echo "Please specify a payment method!"; break;
};
$payment_method = ob_get_clean();
?>

ob_start() will start output buffering (which will also stop output) and ob_get_clean() will end it, returning everything echoed while ob running.

So, for example, if $cardtype is visa, $payment_method will equal to VSA.

Hope it helps.

Note: This might not be a good solution, if possible, please, use solution from any other answer. Pekka's answer is really good one, try his.

edited Feb 3, 2018 at 18:31

answered Feb 4, 2017 at 15:24

user5147563

Collectives™ on Stack Overflow

PHP Get variable to equal value of switch

8 Answers 8

Comments

Comments

Comments

Comments

1 Comment

Comments

5 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

8 Answers 8

Comments

Comments

Comments

Comments

1 Comment

Comments

5 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related