jquery onclick if ...else if ...else not working correctly

Question

Hi I am running an a jQuery function to send some data to an ajax request I have an if statement to get the active elements within a dropdown to pass the selection to the ajax request. Like so:

 $('#filters #region_dd ul.dropdown li a').click(function (e) {
    $('#filters #region_dd ul.dropdown li a').removeClass('active');
    $('#centre_dd > .active').text("Select a Centre").toggleClass('active');
    $('#centre_dd > ul.dropdown li a.active').toggleClass('active');

    console.info('Selected Region: "' + $(this).attr('href') + '"');

    if ($('.date-selection li a.active')) {
      date =  $('.date-selection > li a.active').attr('href');
    } else if($('#year_dd .dropdown.year-selection > li > a.active')) {
      date =  $('#year_dd .dropdown.year-selection > li > a.active').attr('href');
    } else {
      date = null;
    }
    var region = $(this).attr('href');
    filterData.update('/overview', region, null, date);
  });

However the else if condition is never caught even when that .year-selection > li > a.active is true if the .date-selection > li > a.active is active then this passed through. Any ideas what I've doing wrong with my else if??

may be because you are calling .removeClass('active'); before the if condition — Arun P Johny
– Arun P Johny, Commented Mar 22, 2015 at 10:37
not on the .date-selection or .year-selection though @ArunPJohny — user0129e021939232
– user0129e021939232, Commented Mar 22, 2015 at 10:38

Arun P Johny · Accepted Answer · 2015-03-22 10:43:41Z

3

One problem I can see is you are passing a jQuery object to the if condition, which is always truthy, so irrespective of whether there is an element matching the criteria .date-selection li a.active, the if block will get executed.

if ($('.date-selection li a').hasClass('active')) {
    date = $('.date-selection > li a').attr('href');
} else if ($('#year_dd .dropdown.year-selection > li > a').hasClass('active')) {
    date = $('#year_dd .dropdown.year-selection > li > a.active').attr('href');
} else {
    date = null;
}

answered Mar 22, 2015 at 10:43

Arun P Johny

389k68 gold badges532 silver badges532 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

jquery onclick if ...else if ...else not working correctly

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related