Using variable inside array.push() in jquery

Question

I have a for loop in my jquery script

var images[];
for(i=0;i<$('#imageHolder div').length;i++)
{
    images.push($('#imageHolder div:eq( i )').attr('alt'));
    console.log($('#imageHolder div:eq(i )').attr('alt'));
}

I am not able to add the elements to the array and the console.log says undefined in the console. What is my possible error and how that can be corrected?

dfsq · Accepted Answer · 2015-03-26 09:00:59Z

1

jQuery has useful method for this task, called $.fn.map:

var images = $('#imageHolder div').map(function() {
    return $(this).attr('alt');
}).get();

Will produce an array of images alt attributes.

answered Mar 26, 2015 at 9:00

dfsq

193k26 gold badges244 silver badges261 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Pierrickouw · Accepted Answer · 2015-03-26 08:59:56Z

0

You have a typo:

images.push($('#imageHolder div:eq(' + i + ')').attr('alt')); 
                 you need to concat i ^^^^

By the way, don't select your element every time in the for

var divs = $('#imageHolder div');
for(i=0; i < divs.length; i++)

answered Mar 26, 2015 at 8:59

Pierrickouw

4,7341 gold badge34 silver badges29 bronze badges

Comments

Arun P Johny · Accepted Answer · 2015-03-26 09:00:04Z

0

i is a variable so need to use concatenation

$('#imageHolder div:eq('+  i + ')').attr('alt')

A more efficient way is to use .map(), in your case you are evaluating the selector many times which is not a optimal way

var images = $('#imageHolder div').map(function () {
    return $(this).attr('alt')
}).get()

answered Mar 26, 2015 at 9:00

Arun P Johny

389k68 gold badges532 silver badges532 bronze badges

Collectives™ on Stack Overflow

Using variable inside array.push() in jquery

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related